diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-16 09:15:26 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-16 09:15:26 +0900 |
| commit | 4a48e0e954b7afda55ff0419e091790b5b7b9f64 (patch) | |
| tree | ab82158776c4625129edb22c28f9bdcb7a0016a4 /crates/shirabe/tests/io/console_io_test.rs | |
| parent | fdd60a0a66890e049fea3db5c619e64e67e225df (diff) | |
| download | php-shirabe-4a48e0e954b7afda55ff0419e091790b5b7b9f64.tar.gz php-shirabe-4a48e0e954b7afda55ff0419e091790b5b7b9f64.tar.zst php-shirabe-4a48e0e954b7afda55ff0419e091790b5b7b9f64.zip | |
refactor(io): take &str in ConsoleIO write and sanitize
doWrite, doOverwrite and sanitize accept PHP's string|list<string>, which
this port modelled as PhpMixed. Every call site inside ConsoleIO passes a
single string, so take &str and return String instead, dropping the
(array) casts and the to_string_list helper.
Auditor is the only caller that passed a list: it builds table rows, whose
cells must stay separate, so it now sanitizes each cell. select() likewise
sanitizes each choice while projecting them into the keyed form.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/io/console_io_test.rs')
| -rw-r--r-- | crates/shirabe/tests/io/console_io_test.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/crates/shirabe/tests/io/console_io_test.rs b/crates/shirabe/tests/io/console_io_test.rs index b0c6380d..e6b19c05 100644 --- a/crates/shirabe/tests/io/console_io_test.rs +++ b/crates/shirabe/tests/io/console_io_test.rs @@ -291,11 +291,11 @@ fn test_has_authentication() { assert!(!console_io.has_authentication("repoName2")); } -#[ignore = "data provider includes malformed-UTF-8 inputs (e.g. \\xFF, \\xC3\\x28); sanitize() takes PhpMixed::String which is UTF-8-only and cannot carry invalid bytes, so those cases are unrepresentable"] +#[ignore = "data provider includes malformed-UTF-8 inputs (e.g. \\xFF, \\xC3\\x28); sanitize() takes a &str which is UTF-8-only and cannot carry invalid bytes, so those cases are unrepresentable"] #[test] fn test_sanitize() { // TODO(bytes): the data provider includes malformed-UTF-8 inputs (e.g. \xFF, \xC3\x28); - // sanitize() takes PhpMixed::String which is UTF-8-only and cannot carry invalid bytes, so - // those cases are unrepresentable. + // sanitize() takes a &str which is UTF-8-only and cannot carry invalid bytes, so those cases + // are unrepresentable. todo!() } |
