aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests/util
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-12 00:19:10 +0900
committernsfisis <nsfisis@gmail.com>2026-08-12 00:19:36 +0900
commit561924db750cbb4e4c183f9616472ed9a5b0fc7f (patch)
tree13d27f8c4d3a0fca8cfd447ea32befa9aa358228 /crates/shirabe/tests/util
parentdaa1acf091627f4f1af63ad44eee988048fa4136 (diff)
downloadphp-shirabe-561924db750cbb4e4c183f9616472ed9a5b0fc7f.tar.gz
php-shirabe-561924db750cbb4e4c183f9616472ed9a5b0fc7f.tar.zst
php-shirabe-561924db750cbb4e4c183f9616472ed9a5b0fc7f.zip
docs(todo): retag TODO markers by root cause
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests/util')
-rw-r--r--crates/shirabe/tests/util/auth_helper_test.rs4
-rw-r--r--crates/shirabe/tests/util/error_handler_test.rs6
-rw-r--r--crates/shirabe/tests/util/process_executor_test.rs4
-rw-r--r--crates/shirabe/tests/util/remote_filesystem_test.rs10
-rw-r--r--crates/shirabe/tests/util/stream_context_factory_test.rs4
-rw-r--r--crates/shirabe/tests/util/zip_test.rs2
6 files changed, 15 insertions, 15 deletions
diff --git a/crates/shirabe/tests/util/auth_helper_test.rs b/crates/shirabe/tests/util/auth_helper_test.rs
index 2f2feb23..102a798c 100644
--- a/crates/shirabe/tests/util/auth_helper_test.rs
+++ b/crates/shirabe/tests/util/auth_helper_test.rs
@@ -806,7 +806,7 @@ fn test_add_authentication_header_with_custom_headers() {
#[ignore = "exercises the deprecated addAuthenticationHeader wrapper (not ported) which relies on \
trigger_error/E_USER_DEPRECATED; the PHP error-handler subsystem is not modeled"]
fn test_add_authentication_header_is_working() {
- // TODO(phase-d): see test_add_authentication_header_with_custom_headers above — same
+ // TODO(php-runtime): see test_add_authentication_header_with_custom_headers above — same
// unported addAuthenticationHeader deprecated wrapper.
todo!()
}
@@ -815,7 +815,7 @@ fn test_add_authentication_header_is_working() {
#[ignore = "exercises the deprecated addAuthenticationHeader wrapper (not ported) which relies on \
trigger_error/E_USER_DEPRECATED converted to a RuntimeException via set_error_handler; not modeled"]
fn test_add_authentication_header_deprecation() {
- // TODO(phase-d): asserts that calling addAuthenticationHeader itself raises a
+ // TODO(php-runtime): asserts that calling addAuthenticationHeader itself raises a
// RuntimeException via a custom set_error_handler converting E_USER_DEPRECATED; same
// unported wrapper and unmodeled error-handler subsystem as the two tests above.
todo!()
diff --git a/crates/shirabe/tests/util/error_handler_test.rs b/crates/shirabe/tests/util/error_handler_test.rs
index efaf4e11..9a34fd73 100644
--- a/crates/shirabe/tests/util/error_handler_test.rs
+++ b/crates/shirabe/tests/util/error_handler_test.rs
@@ -30,7 +30,7 @@ impl Drop for TearDown {
#[ignore = "depends on PHP runtime routing an undefined-index notice through set_error_handler; no Rust equivalent for $array['baz'] triggering ErrorHandler::handle"]
#[test]
fn test_error_handler_capture_notice() {
- // TODO(phase-d): depends on PHP runtime routing an undefined-index notice through
+ // TODO(php-runtime): depends on PHP runtime routing an undefined-index notice through
// set_error_handler; no Rust equivalent for $array['baz'] triggering
// ErrorHandler::handle.
todo!()
@@ -39,7 +39,7 @@ fn test_error_handler_capture_notice() {
#[ignore = "depends on PHP runtime emitting a TypeError/warning from array_merge([], 'string') via set_error_handler; no Rust equivalent"]
#[test]
fn test_error_handler_capture_warning() {
- // TODO(phase-d): depends on PHP runtime emitting a TypeError/warning from
+ // TODO(php-runtime): depends on PHP runtime emitting a TypeError/warning from
// array_merge([], 'string') via set_error_handler; no Rust equivalent.
todo!()
}
@@ -47,7 +47,7 @@ fn test_error_handler_capture_warning() {
#[ignore = "depends on the PHP @ error-suppression operator and trigger_error routing through set_error_handler; no Rust equivalent"]
#[test]
fn test_error_handler_respects_at_operator() {
- // TODO(phase-d): depends on the PHP @ error-suppression operator and trigger_error
+ // TODO(php-runtime): depends on the PHP @ error-suppression operator and trigger_error
// routing through set_error_handler; no Rust equivalent.
todo!()
}
diff --git a/crates/shirabe/tests/util/process_executor_test.rs b/crates/shirabe/tests/util/process_executor_test.rs
index 9599775e..93e74a12 100644
--- a/crates/shirabe/tests/util/process_executor_test.rs
+++ b/crates/shirabe/tests/util/process_executor_test.rs
@@ -2,7 +2,7 @@
// These run real subprocesses (capturing output/stderr/timeout) and assert ProcessExecutor's
// password hiding, line splitting and argument escaping. A few data points remain unportable —
-// see the individual `// TODO(phase-d)` comments below.
+// see the individual `// TODO(async)` comments below.
use shirabe::io::ConsoleIO;
use shirabe::io::IOInterface;
@@ -179,7 +179,7 @@ fn test_console_io_does_not_format_symfony_console_style() {
#[ignore = "none of the three symbols this test drives exist: execute_async returns a plain future with no cancel(), and ProcessExecutor has no count_active_jobs or wait (PHP's $jobs/$maxJobs queue is a tokio semaphore here)"]
#[test]
fn test_execute_async_cancel() {
- // TODO(phase-d): PHP's executeAsync returns a React\Promise\PromiseInterface with cancel(),
+ // TODO(async): PHP's executeAsync returns a React\Promise\PromiseInterface with cancel(),
// and the test reads countActiveJobs() around it and then calls wait(). execute_async here
// returns a plain future with no cancel(), and ProcessExecutor has neither count_active_jobs
// nor wait: the PHP job queue those methods expose is a tokio semaphore in this port.
diff --git a/crates/shirabe/tests/util/remote_filesystem_test.rs b/crates/shirabe/tests/util/remote_filesystem_test.rs
index 43f0aae0..6d21732f 100644
--- a/crates/shirabe/tests/util/remote_filesystem_test.rs
+++ b/crates/shirabe/tests/util/remote_filesystem_test.rs
@@ -274,10 +274,10 @@ fn test_copy() {
#[test]
#[ignore = "requires a MockObject subclass of RemoteFilesystem overriding private get_remote_contents; no subclass-mocking infrastructure exists"]
fn test_copy_with_no_retry_on_failure() {
- // TODO(phase-d): requires a MockObject subclass of RemoteFilesystem overriding the
+ // TODO(mock): requires a MockObject subclass of RemoteFilesystem overriding the
// private get_remote_contents method. There is no subclass-mocking infrastructure in
// Rust for this, and get_remote_contents's http(s) branch is itself still a
- // TODO(phase-c) stub (always returns Ok(None)), so there is nothing yet to intercept
+ // TODO(http) stub (always returns Ok(None)), so there is nothing yet to intercept
// even with a seam.
todo!()
}
@@ -285,10 +285,10 @@ fn test_copy_with_no_retry_on_failure() {
#[test]
#[ignore = "requires MockObject subclasses overriding RemoteFilesystem::get_remote_contents and AuthHelper::prompt_auth_if_needed; no subclass-mocking infrastructure exists"]
fn test_copy_with_success_on_retry() {
- // TODO(phase-d): requires MockObject subclasses overriding
+ // TODO(mock): requires MockObject subclasses overriding
// RemoteFilesystem::get_remote_contents and AuthHelper::prompt_auth_if_needed to
// simulate a first failure and a retried success; same missing-subclass-mocking-
- // infrastructure and TODO(phase-c) http(s)-stub blockers as
+ // infrastructure and TODO(http) http(s)-stub blockers as
// test_copy_with_no_retry_on_failure above.
todo!()
}
@@ -350,7 +350,7 @@ fn provide_bitbucket_public_download_urls() -> Vec<(&'static str, &'static str)>
}
#[test]
-#[ignore = "performs a real network download; get_remote_contents has no stream layer (TODO(phase-c)) and returns None, so getContents raises a TransportException"]
+#[ignore = "performs a real network download; get_remote_contents has no stream layer (TODO(http)) and returns None, so getContents raises a TransportException"]
fn test_bit_bucket_public_download() {
for (url, contents) in provide_bitbucket_public_download_urls() {
let io: std::rc::Rc<std::cell::RefCell<dyn IOInterface>> =
diff --git a/crates/shirabe/tests/util/stream_context_factory_test.rs b/crates/shirabe/tests/util/stream_context_factory_test.rs
index f9d840cf..a2a9cb44 100644
--- a/crates/shirabe/tests/util/stream_context_factory_test.rs
+++ b/crates/shirabe/tests/util/stream_context_factory_test.rs
@@ -100,7 +100,7 @@ impl Drop for TearDown {
}
}
-// TODO(phase-d): PHP's dataGetContext second data set passes a `notification` closure in both
+// TODO(type-model): PHP's dataGetContext second data set passes a `notification` closure in both
// the default and expected params; PhpMixed has no closure variant, so that data set (and thus
// the all-or-nothing testGetContext, which a data provider test cannot partially skip) cannot be
// expressed.
@@ -110,7 +110,7 @@ impl Drop for TearDown {
fn test_get_context() {
let _tear_down = TearDown;
set_up();
- // TODO(phase-d): dataGetContext's second data set passes a `notification` closure in
+ // TODO(type-model): dataGetContext's second data set passes a `notification` closure in
// params; PhpMixed cannot represent a PHP closure, so that data set (and thus the
// all-or-nothing testGetContext, which a data provider test cannot partially skip) is
// unportable.
diff --git a/crates/shirabe/tests/util/zip_test.rs b/crates/shirabe/tests/util/zip_test.rs
index e3e976de..569ac7a2 100644
--- a/crates/shirabe/tests/util/zip_test.rs
+++ b/crates/shirabe/tests/util/zip_test.rs
@@ -11,7 +11,7 @@ fn fixture(name: &str) -> String {
)
}
-// TODO(phase-d): PHP runs this test only when the zip extension is NOT loaded (it is
+// TODO(php-runtime): PHP runs this test only when the zip extension is NOT loaded (it is
// markTestSkipped otherwise). The Rust port links zip support unconditionally, so the
// "extension not loaded" precondition cannot exist and the expected RuntimeException
// ("The Zip Util requires PHP's zip extension") is unreachable by design.