aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-08 03:52:33 +0900
committernsfisis <nsfisis@gmail.com>2026-08-08 10:38:35 +0900
commit0209f63210e5b547b5c6b73367bb80ea86c255ec (patch)
tree6ce0f50f343fc51da0db413278093d63d0a9fe70 /crates/shirabe/tests
parentb4f16a379e919eefc2cb37bcddee589c0f26eaad (diff)
downloadphp-shirabe-0209f63210e5b547b5c6b73367bb80ea86c255ec.tar.gz
php-shirabe-0209f63210e5b547b5c6b73367bb80ea86c255ec.tar.zst
php-shirabe-0209f63210e5b547b5c6b73367bb80ea86c255ec.zip
feat(composer): bake the dev build warning deadline in at build time
Composer defines COMPOSER_DEV_WARNING_TIME from its phar stub when the compiled version is a commit hash rather than a tag, so the value exists only in the build artifact. It was a todo!() in the PHP shim, leaving the warning branch in Application::do_run unreachable. A build script now derives it the way Compiler does, from git describe and the HEAD commit date, and composer::COMPOSER_DEV_WARNING_TIME holds the result as a Rust constant instead of a runtime-defined one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests')
-rw-r--r--crates/shirabe/tests/application_test.rs7
1 files changed, 1 insertions, 6 deletions
diff --git a/crates/shirabe/tests/application_test.rs b/crates/shirabe/tests/application_test.rs
index 6ce9166b..794a4352 100644
--- a/crates/shirabe/tests/application_test.rs
+++ b/crates/shirabe/tests/application_test.rs
@@ -1,10 +1,5 @@
//! ref: composer/tests/Composer/Test/ApplicationTest.php
-// These drive the console Application (doRun, command resolution, plugin disabling).
-// The tests exercising do_run's script-command registration (a todo!() pending the
-// Symfony command-registry model), or a runtime define() of COMPOSER_DEV_WARNING_TIME,
-// remain unportable.
-
#[path = "common/bootstrap.rs"]
mod bootstrap;
#[path = "common/test_case.rs"]
@@ -40,7 +35,7 @@ impl Drop for TearDown {
}
}
-#[ignore = "shirabe_php_shim::define is a todo!() (there is no runtime constant registry), so COMPOSER_DEV_WARNING_TIME cannot be defined and defined() — a fixed matches! that omits it — keeps the warning branch unreachable"]
+#[ignore = "the dev warning deadline is a Rust constant baked in by build.rs, so a runtime define() of COMPOSER_DEV_WARNING_TIME cannot make Application take the warning branch"]
#[test]
fn test_dev_warning() {
let _tear_down = TearDown;