diff options
| author | nsfisis <nsfisis@gmail.com> | 2026-08-09 06:50:56 +0900 |
|---|---|---|
| committer | nsfisis <nsfisis@gmail.com> | 2026-08-09 06:50:56 +0900 |
| commit | 6b83e68d7961f150ec15dd59d457d519e0bf8663 (patch) | |
| tree | 8342c9d7d31679c669e14a76d0349c777f6c2566 /crates/shirabe/tests | |
| parent | ff17dcdb757656c5e81b10070a7bbcc4ef3e97f7 (diff) | |
| download | php-shirabe-6b83e68d7961f150ec15dd59d457d519e0bf8663.tar.gz php-shirabe-6b83e68d7961f150ec15dd59d457d519e0bf8663.tar.zst php-shirabe-6b83e68d7961f150ec15dd59d457d519e0bf8663.zip | |
refactor(env): split and join PATH lists with std::env
The shim's PATH_SEPARATOR was hardcoded to ":", so every PATH list was
split and joined on the wrong character off Unix. std::env::split_paths
and join_paths use the platform's separator, which also lets the bin-dir
membership test in EventDispatcher compare list entries instead of
regex-matching the raw PATH string.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests')
| -rw-r--r-- | crates/shirabe/tests/util/ini_helper_test.rs | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/crates/shirabe/tests/util/ini_helper_test.rs b/crates/shirabe/tests/util/ini_helper_test.rs index 0b3835a0..90015169 100644 --- a/crates/shirabe/tests/util/ini_helper_test.rs +++ b/crates/shirabe/tests/util/ini_helper_test.rs @@ -2,7 +2,7 @@ use shirabe::util::ini_helper::IniHelper; use shirabe::util::platform::Platform; -use shirabe_php_shim::{PATH_SEPARATOR, getenv, putenv}; +use shirabe_php_shim::{getenv, putenv}; #[allow(dead_code)] fn set_up() -> TearDown { @@ -39,7 +39,12 @@ impl Drop for TearDown { } fn set_env(paths: &[&str]) { - unsafe { putenv("COMPOSER_ORIGINAL_INIS", paths.join(PATH_SEPARATOR)) }; + unsafe { + putenv( + "COMPOSER_ORIGINAL_INIS", + std::env::join_paths(paths).unwrap(), + ) + }; } #[test] |
