aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe/tests
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-16 13:59:28 +0900
committernsfisis <nsfisis@gmail.com>2026-08-16 13:59:28 +0900
commitb4ab3df2ec85fbe477d7721344a8cd3630b437a1 (patch)
treeeb618cbbdfa46cf829031f9c427dc09ef7584831 /crates/shirabe/tests
parentbaf9aff3134ac5a10260d3be421a2c17a0180d64 (diff)
downloadphp-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.gz
php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.zst
php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.zip
feat(plugin): guard Rust-owned classes the worker has no proxy for
The worker's autoloader fell through to the real Composer source for every Rust-owned FQCN without a proxy stub, so plugin code doing `new Filesystem()` or subclassing `LibraryInstaller` silently ran on a second instance the Rust side never sees. An unimplemented part of the plugin API has to fail with an explicit error naming it, not quietly work on a disconnected copy. The stub generator now emits a guard class for each of those FQCNs: the real declaration, hierarchy and constants, with every constructor and method raising an explicit error. References satisfied by the declaration alone (`instanceof`, `X::class`, `Link::TYPE_REQUIRE`) keep working. Two FQCNs stay resolvable to the real class, each listed with the worker-side mechanism that makes a natively constructed instance correct. The error had nowhere to go: `Installer::run` dropped the `Result` of both `dispatch_script` calls, so an exception from a listener ended in exit 0. Both propagate now, the way the exception does upstream. Three real-plugin E2E comparisons stop at a guard and are ignored, each naming the class it needs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'crates/shirabe/tests')
-rw-r--r--crates/shirabe/tests/plugin/e2e_extension_installer_test.rs4
-rw-r--r--crates/shirabe/tests/plugin/e2e_installers_test.rs7
-rw-r--r--crates/shirabe/tests/plugin/e2e_normalize_test.rs10
3 files changed, 18 insertions, 3 deletions
diff --git a/crates/shirabe/tests/plugin/e2e_extension_installer_test.rs b/crates/shirabe/tests/plugin/e2e_extension_installer_test.rs
index 9a95888c..0465757a 100644
--- a/crates/shirabe/tests/plugin/e2e_extension_installer_test.rs
+++ b/crates/shirabe/tests/plugin/e2e_extension_installer_test.rs
@@ -117,6 +117,10 @@ fn run_install(work: &Path, program: &str, args: &[&str]) -> InstallRun {
}
}
+// TODO(plugin): the plugin's post-install listener does `new Composer\Util\Filesystem()`, and
+// the guard class the worker loads for that FQCN raises an explicit error: the Rust side owns
+// Filesystem and has no proxy for plugin-constructed instances of it.
+#[ignore = "Filesystem is Rust-owned and has no proxy the plugin can construct; see the TODO(plugin) above"]
#[test]
fn test_extension_installer_install_matches_upstream_composer() {
if !php_runtime_available() {
diff --git a/crates/shirabe/tests/plugin/e2e_installers_test.rs b/crates/shirabe/tests/plugin/e2e_installers_test.rs
index 67c51b5c..9d8693fb 100644
--- a/crates/shirabe/tests/plugin/e2e_installers_test.rs
+++ b/crates/shirabe/tests/plugin/e2e_installers_test.rs
@@ -99,6 +99,11 @@ fn edit(path: &Path, from: &str, to: &str) {
std::fs::write(path, text.replace(from, to)).unwrap();
}
+// TODO(plugin): the plugin's Installer extends Composer\Installer\LibraryInstaller, whose
+// constructor the guard class the worker loads rejects with an explicit error: the Rust side owns
+// LibraryInstaller and has no proxy a plugin can subclass. The same applies to the two tests
+// below.
+#[ignore = "LibraryInstaller is Rust-owned and has no proxy a plugin can subclass; see the TODO(plugin) above"]
#[test]
fn test_composer_installers_matches_upstream_composer() {
if !php_runtime_available() || !plugin_fetched() {
@@ -139,6 +144,7 @@ fn test_composer_installers_matches_upstream_composer() {
/// The rest of the installer contract: `update` reinstalls a package in place, a second `install`
/// runs over an already-installed tree, and `remove` reaches the plugin's own `uninstall()`
/// override — the one that chains onto the promise `LibraryInstaller::uninstall` returns.
+#[ignore = "LibraryInstaller is Rust-owned and has no proxy a plugin can subclass; see the TODO(plugin) above"]
#[test]
fn test_composer_installers_update_and_remove_match_upstream_composer() {
if !php_runtime_available() || !plugin_fetched() {
@@ -203,6 +209,7 @@ fn test_composer_installers_update_and_remove_match_upstream_composer() {
/// The plugin's configuration surface: `installer-paths` in the root package's extra (both the
/// `type:` and the package-name matcher, with `{$name}` templating) and `installer-name` in the
/// installed package's own extra. Both are read back through the package proxy.
+#[ignore = "LibraryInstaller is Rust-owned and has no proxy a plugin can subclass; see the TODO(plugin) above"]
#[test]
fn test_composer_installers_custom_paths_match_upstream_composer() {
if !php_runtime_available() || !plugin_fetched() {
diff --git a/crates/shirabe/tests/plugin/e2e_normalize_test.rs b/crates/shirabe/tests/plugin/e2e_normalize_test.rs
index ccfdb596..9fb49bab 100644
--- a/crates/shirabe/tests/plugin/e2e_normalize_test.rs
+++ b/crates/shirabe/tests/plugin/e2e_normalize_test.rs
@@ -1,7 +1,7 @@
//! ergebnis/composer-normalize E2E compatibility check: upstream Composer and Shirabe each
-//! install the pinned plugin (with its real dependency tree) and the `list`/`help` renderings
-//! of its command are compared; the execution comparison is present but ignored until the
-//! worker can construct a second native Composer instance.
+//! install the pinned plugin (with its real dependency tree); the `list`/`help` renderings of its
+//! command are compared, as is running the command. Both comparisons are ignored, each for the
+//! reason recorded on it.
//!
//! Prerequisites: the PHP runtime, the Composer checkout, and the pinned packages in
//! `fixtures/e2e-normalize/ext/` — run `fixtures/e2e-normalize/fetch` once to populate it.
@@ -60,6 +60,10 @@ fn normalize_lines(stdout: &str) -> Vec<&str> {
.collect()
}
+// TODO(plugin): NormalizePlugin::getCommands() does `new Composer\Factory()`, and the guard
+// class the worker loads for that FQCN raises an explicit error: Factory has no counterpart the
+// worker can run, so the plugin's command never reaches the command list.
+#[ignore = "the plugin's command provider constructs Composer\\Factory, which the worker has no counterpart for; see the TODO(plugin) above"]
#[test]
fn test_normalize_listing_matches_upstream_composer() {
if !php_runtime_available() {