aboutsummaryrefslogtreecommitdiffhomepage
path: root/docs/dev/xdebug.md
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-17 07:13:02 +0900
committernsfisis <nsfisis@gmail.com>2026-08-17 07:13:02 +0900
commitc7aa10384a2548167466b4c61f9eff29ed8611f6 (patch)
tree4d0800f425eaea2a8fb8ee3f551f865f570d19f8 /docs/dev/xdebug.md
parent890c8213d15424bb714f2ff06d562ca2538c24e4 (diff)
downloadphp-shirabe-c7aa10384a2548167466b4c61f9eff29ed8611f6.tar.gz
php-shirabe-c7aa10384a2548167466b4c61f9eff29ed8611f6.tar.zst
php-shirabe-c7aa10384a2548167466b4c61f9eff29ed8611f6.zip
refactor(preg): report unmatched groups as null throughout
The shim carried two reporting modes for the preg_* $matches maps: PHP's default (trailing unmatched groups dropped, interior ones ""), and the PREG_UNMATCHED_AS_NULL form, picked by calling a *_unmatched_as_null() variant. The regex crate hands out Option<Match>, which maps onto the null form directly, and no caller distinguished a dropped group from a null one -- preg_match() and preg_match_all2() already reported nulls unconditionally. Keep only the null form; the shim API no longer mirrors PHP's flag set, which is intended. Preg::is_match_with_indexed_captures() modelled PHP's "unset" as a truncated Vec<String>, and now returns Vec<Option<String>>. That is what Composer actually does: Preg::isMatch() always sets PREG_UNMATCHED_AS_NULL, and its callers test groups with `!== null`. preg_match_all(), preg_match_all_set_order() and preg_split_delim_capture() still hand back Vec<String> and keep the "" form. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'docs/dev/xdebug.md')
0 files changed, 0 insertions, 0 deletions