aboutsummaryrefslogtreecommitdiffhomepage
path: root/scripts/linters/lint
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-16 16:25:37 +0900
committernsfisis <nsfisis@gmail.com>2026-08-16 17:34:46 +0900
commit1747352a5b4995eee390ba9eba2e77ec2c1e4586 (patch)
tree492be0a100f3bf9ca6fa1989010632276a6495ed /scripts/linters/lint
parent4065d8842beb5d1648131bd5b1951adf7a27b5b7 (diff)
downloadphp-shirabe-1747352a5b4995eee390ba9eba2e77ec2c1e4586.tar.gz
php-shirabe-1747352a5b4995eee390ba9eba2e77ec2c1e4586.tar.zst
php-shirabe-1747352a5b4995eee390ba9eba2e77ec2c1e4586.zip
build(linters): forbid direct std::env access
PHP keeps three separate environment storages and docs/dev/env-vars- porting.md maps each to its own shim construct. Reaching for std::env silently picks one, so the porting target has to be chosen by reading the PHP source rather than by whichever Rust call is at hand. Detect var/var_os/vars/vars_os/set_var/remove_var. current_dir, args, consts, temp_dir, current_exe and the path split/join helpers are not environment storage and stay allowed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'scripts/linters/lint')
-rwxr-xr-xscripts/linters/lint8
1 files changed, 8 insertions, 0 deletions
diff --git a/scripts/linters/lint b/scripts/linters/lint
index e90c3e0c..150e1f1a 100755
--- a/scripts/linters/lint
+++ b/scripts/linters/lint
@@ -9,6 +9,7 @@ use Shirabe\Lint\Linters\CargoWorkspaceDependencies;
use Shirabe\Lint\Linters\ContiguousUseBlock;
use Shirabe\Lint\Linters\NoBannedUse;
use Shirabe\Lint\Linters\NoDecorativeSectionComment;
+use Shirabe\Lint\Linters\NoDirectEnvAccess;
use Shirabe\Lint\Linters\NoExceptionDowncast;
use Shirabe\Lint\Linters\NoFormatTrailingComma;
use Shirabe\Lint\Linters\NoHaltCompilerLiteral;
@@ -28,6 +29,13 @@ $runner = new Runner($rootDir, [
[new NoDecorativeSectionComment(), [
'crates/shirabe-semver/src/version_parser.rs',
]],
+ [new NoDirectEnvAccess(), [
+ // Defines the shim the rule points at.
+ 'crates/shirabe-php-shim/src/env.rs',
+ // Build scripts read Cargo's own variables, and run before the shim exists.
+ 'crates/shirabe-php-rpc/build.rs',
+ 'crates/shirabe/build.rs',
+ ]],
[new NoExceptionDowncast(), [
// Defines the box and the walk the rule points at.
'crates/shirabe-php-shim/src/exception.rs',