aboutsummaryrefslogtreecommitdiffhomepage
path: root/scripts/plugin-stub-generator/guard-exemptions.list
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-16 13:59:28 +0900
committernsfisis <nsfisis@gmail.com>2026-08-16 13:59:28 +0900
commitb4ab3df2ec85fbe477d7721344a8cd3630b437a1 (patch)
treeeb618cbbdfa46cf829031f9c427dc09ef7584831 /scripts/plugin-stub-generator/guard-exemptions.list
parentbaf9aff3134ac5a10260d3be421a2c17a0180d64 (diff)
downloadphp-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.gz
php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.zst
php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.zip
feat(plugin): guard Rust-owned classes the worker has no proxy for
The worker's autoloader fell through to the real Composer source for every Rust-owned FQCN without a proxy stub, so plugin code doing `new Filesystem()` or subclassing `LibraryInstaller` silently ran on a second instance the Rust side never sees. An unimplemented part of the plugin API has to fail with an explicit error naming it, not quietly work on a disconnected copy. The stub generator now emits a guard class for each of those FQCNs: the real declaration, hierarchy and constants, with every constructor and method raising an explicit error. References satisfied by the declaration alone (`instanceof`, `X::class`, `Link::TYPE_REQUIRE`) keep working. Two FQCNs stay resolvable to the real class, each listed with the worker-side mechanism that makes a natively constructed instance correct. The error had nowhere to go: `Installer::run` dropped the `Result` of both `dispatch_script` calls, so an exception from a listener ended in exit 0. Both propagate now, the way the exception does upstream. Three real-plugin E2E comparisons stop at a guard and are ignored, each naming the class it needs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'scripts/plugin-stub-generator/guard-exemptions.list')
-rw-r--r--scripts/plugin-stub-generator/guard-exemptions.list14
1 files changed, 14 insertions, 0 deletions
diff --git a/scripts/plugin-stub-generator/guard-exemptions.list b/scripts/plugin-stub-generator/guard-exemptions.list
new file mode 100644
index 00000000..90adcb20
--- /dev/null
+++ b/scripts/plugin-stub-generator/guard-exemptions.list
@@ -0,0 +1,14 @@
+# Classes the Rust side owns that the worker still resolves to the real Composer implementation,
+# so no guard is emitted for them. An entry belongs here only when the worker has a mechanism that
+# makes a natively constructed instance correct; without one the class must be guarded, or code
+# running here would silently work on an instance the Rust side never sees. One FQCN per line,
+# each with the mechanism that justifies it.
+
+# The wire codec revives values of this class from the object record serialize() writes for them
+# (php/runtime/Shirabe/MaterializedValue.php), so the real declaration has to stay loadable.
+Composer\Package\Link
+
+# Real Composer\Command code running in this worker constructs one (BaseCommand::initialize), and
+# the dual-mode Composer\EventDispatcher\Event (php/runtime/) carries a natively constructed event
+# to the Rust side as a P-table entity.
+Composer\Plugin\PreCommandRunEvent