aboutsummaryrefslogtreecommitdiffhomepage
path: root/scripts/plugin-stub-generator/src/Generator.php
diff options
context:
space:
mode:
authornsfisis <nsfisis@gmail.com>2026-08-16 13:59:28 +0900
committernsfisis <nsfisis@gmail.com>2026-08-16 13:59:28 +0900
commitb4ab3df2ec85fbe477d7721344a8cd3630b437a1 (patch)
treeeb618cbbdfa46cf829031f9c427dc09ef7584831 /scripts/plugin-stub-generator/src/Generator.php
parentbaf9aff3134ac5a10260d3be421a2c17a0180d64 (diff)
downloadphp-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.gz
php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.tar.zst
php-shirabe-b4ab3df2ec85fbe477d7721344a8cd3630b437a1.zip
feat(plugin): guard Rust-owned classes the worker has no proxy for
The worker's autoloader fell through to the real Composer source for every Rust-owned FQCN without a proxy stub, so plugin code doing `new Filesystem()` or subclassing `LibraryInstaller` silently ran on a second instance the Rust side never sees. An unimplemented part of the plugin API has to fail with an explicit error naming it, not quietly work on a disconnected copy. The stub generator now emits a guard class for each of those FQCNs: the real declaration, hierarchy and constants, with every constructor and method raising an explicit error. References satisfied by the declaration alone (`instanceof`, `X::class`, `Link::TYPE_REQUIRE`) keep working. Two FQCNs stay resolvable to the real class, each listed with the worker-side mechanism that makes a natively constructed instance correct. The error had nowhere to go: `Installer::run` dropped the `Result` of both `dispatch_script` calls, so an exception from a listener ended in exit 0. Both propagate now, the way the exception does upstream. Three real-plugin E2E comparisons stop at a guard and are ignored, each naming the class it needs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Diffstat (limited to 'scripts/plugin-stub-generator/src/Generator.php')
-rw-r--r--scripts/plugin-stub-generator/src/Generator.php29
1 files changed, 5 insertions, 24 deletions
diff --git a/scripts/plugin-stub-generator/src/Generator.php b/scripts/plugin-stub-generator/src/Generator.php
index dd62da60..0b8ef037 100644
--- a/scripts/plugin-stub-generator/src/Generator.php
+++ b/scripts/plugin-stub-generator/src/Generator.php
@@ -159,7 +159,7 @@ final class Generator
return [];
}
$surface = [];
- $parentFqcn = $class->extends === null ? null : $this->resolvedName($class->extends);
+ $parentFqcn = $class->extends === null ? null : SourceFile::resolvedName($class->extends);
if ($parentFqcn !== null) {
$surface = $this->surfaces[$parentFqcn] ?? $this->surfaceFromRealClass($parentFqcn);
}
@@ -195,7 +195,7 @@ final class Generator
. '; only rust-proxy and contract classes can become proxy stubs';
}
- $parentFqcn = $class->extends === null ? null : $this->resolvedName($class->extends);
+ $parentFqcn = $class->extends === null ? null : SourceFile::resolvedName($class->extends);
$isRoot = $parentFqcn === null;
if ($parentFqcn !== null && !isset($this->targetSet[$parentFqcn])) {
if (isset($this->runtimeSet[$parentFqcn])) {
@@ -348,7 +348,7 @@ final class Generator
$header = "// Generated by scripts/plugin-stub-generator; do not edit by hand.\n"
. "// Proxy stub for $fqcn: the public surface forwards to the Rust-side entity over RPC.";
$text = "<?php\n\n$header\n\nnamespace {$file->namespace};\n\n";
- $uses = $this->usedImports($file, $decl . "\n" . $body);
+ $uses = $file->importsUsedBy($decl . "\n" . $body);
if ($uses !== '') {
$text .= $uses . "\n\n";
}
@@ -446,11 +446,11 @@ final class Generator
}
$out[] = $file;
foreach ($file->classLike->extends as $parent) {
- $visit($this->resolvedName($parent));
+ $visit(SourceFile::resolvedName($parent));
}
};
foreach ($class->implements as $interface) {
- $visit($this->resolvedName($interface));
+ $visit(SourceFile::resolvedName($interface));
}
return $out;
}
@@ -527,23 +527,4 @@ final class Generator
}
return $fingerprint;
}
-
- /** The original file's imports, restricted to names the emitted stub actually uses. */
- private function usedImports(SourceFile $file, string $emittedText): string
- {
- $kept = [];
- foreach ($file->aliases as $alias => $fqcn) {
- if (preg_match('/(?<![\\\\$\w])' . preg_quote($alias, '/') . '\b/', $emittedText) === 1) {
- $kept[] = 'use ' . $fqcn
- . (str_ends_with($fqcn, '\\' . $alias) || $fqcn === $alias ? '' : " as $alias") . ';';
- }
- }
- return implode("\n", $kept);
- }
-
- private function resolvedName(Name $name): string
- {
- $resolved = $name->getAttribute('resolvedName');
- return $resolved instanceof Name ? $resolved->toString() : $name->toString();
- }
}