diff options
Diffstat (limited to 'crates/shirabe-class-map-generator')
| -rw-r--r-- | crates/shirabe-class-map-generator/Cargo.toml | 1 | ||||
| -rw-r--r-- | crates/shirabe-class-map-generator/src/php_file_parser.rs | 11 |
2 files changed, 6 insertions, 6 deletions
diff --git a/crates/shirabe-class-map-generator/Cargo.toml b/crates/shirabe-class-map-generator/Cargo.toml index b34a1406..4d66ac00 100644 --- a/crates/shirabe-class-map-generator/Cargo.toml +++ b/crates/shirabe-class-map-generator/Cargo.toml @@ -9,6 +9,7 @@ license.workspace = true [dependencies] shirabe-pcre.workspace = true +shirabe-php-rpc.workspace = true shirabe-php-shim.workspace = true shirabe-symfony-finder.workspace = true anyhow.workspace = true diff --git a/crates/shirabe-class-map-generator/src/php_file_parser.rs b/crates/shirabe-class-map-generator/src/php_file_parser.rs index f71b993a..0c82a558 100644 --- a/crates/shirabe-class-map-generator/src/php_file_parser.rs +++ b/crates/shirabe-class-map-generator/src/php_file_parser.rs @@ -4,8 +4,8 @@ use crate::php_file_cleaner::PhpFileCleaner; use indexmap::IndexMap; use shirabe_pcre::{CaptureKey, Preg}; use shirabe_php_shim::{ - PHP_EOL, PHP_VERSION_ID, RuntimeException, file_exists, file_get_contents, function_exists, - is_file, is_readable, ltrim, php_strip_whitespace, str_replace_array, strrpos, substr, trim, + PHP_EOL, RuntimeException, file_exists, file_get_contents, function_exists, is_file, + is_readable, ltrim, php_strip_whitespace, str_replace_array, strrpos, substr, trim, }; use std::sync::OnceLock; @@ -176,10 +176,9 @@ impl PhpFileParser { EXTRA_TYPES.get_or_init(|| { let mut extra_types = String::new(); let mut extra_types_array: Vec<String> = vec![]; - // TODO(php-runtime): whether `enum` is scanned for belongs to the runtime that loads - // the generated class map, i.e. the worker, while PHP_VERSION_ID is the version this - // build models. PHP also scans for enums on HHVM 3.3 and above. - if PHP_VERSION_ID >= 80100 { + // TODO(port): PHP also scans for enums on HHVM 3.3 and above + // (`defined('HHVM_VERSION') && version_compare(HHVM_VERSION, '3.3', '>=')`). + if shirabe_php_rpc::get_php_version().version_id >= 80100 { extra_types += "|enum"; extra_types_array = vec!["enum".to_string()]; } |
