diff options
Diffstat (limited to 'crates/shirabe-external-packages/src/symfony')
5 files changed, 10 insertions, 10 deletions
diff --git a/crates/shirabe-external-packages/src/symfony/console/command/command.rs b/crates/shirabe-external-packages/src/symfony/console/command/command.rs index 2af60db0..f9808878 100644 --- a/crates/shirabe-external-packages/src/symfony/console/command/command.rs +++ b/crates/shirabe-external-packages/src/symfony/console/command/command.rs @@ -61,7 +61,7 @@ impl CommandData { pub const DEFAULT_DESCRIPTION: Option<&'static str> = None; pub fn get_default_name() -> Option<String> { - // TODO(review): PHP uses ReflectionClass to read the #[AsCommand] attribute + // TODO(phase-c): PHP uses ReflectionClass to read the #[AsCommand] attribute // and ReflectionProperty to check that `$defaultName` is declared on the late-static // class itself (not inherited). Reflection-based late static binding cannot be // reproduced in Phase A; human review needed for the porting strategy. @@ -69,7 +69,7 @@ impl CommandData { } pub fn get_default_description() -> Option<String> { - // TODO(review): same Reflection/late-static-binding concern as get_default_name(). + // TODO(phase-c): same Reflection/late-static-binding concern as get_default_name(). todo!() } @@ -429,7 +429,7 @@ pub trait Command: std::fmt::Debug + shirabe_php_shim::AsAny + shirabe_php_shim: self.initialize(input.clone(), output.clone())?; if let Some(process_title) = self.get_process_title() { - // TODO: PHP probes for cli_set_process_title / setproctitle availability. + // TODO(phase-c): PHP probes for cli_set_process_title / setproctitle availability. if shirabe_php_shim::function_exists("cli_set_process_title") { if !shirabe_php_shim::cli_set_process_title(&process_title) { if shirabe_php_shim::PHP_OS == "Darwin" { @@ -874,7 +874,7 @@ impl Command for CommandData { &self, code: Box<dyn Fn(&mut dyn InputInterface, &mut dyn OutputInterface) -> PhpMixed>, ) { - // TODO: PHP rebinds an unbound Closure's $this to the command instance via + // TODO(php-runtime): PHP rebinds an unbound Closure's $this to the command instance via // ReflectionFunction/Closure::bind. Rust closures have no `$this` rebinding; // the closure is stored as-is. *self.code.borrow_mut() = Some(code); diff --git a/crates/shirabe-external-packages/src/symfony/console/formatter/output_formatter.rs b/crates/shirabe-external-packages/src/symfony/console/formatter/output_formatter.rs index 6651d9cd..bb04f61d 100644 --- a/crates/shirabe-external-packages/src/symfony/console/formatter/output_formatter.rs +++ b/crates/shirabe-external-packages/src/symfony/console/formatter/output_formatter.rs @@ -255,7 +255,7 @@ impl OutputFormatterInterface for OutputFormatter { // PHP returns the shared style instance; ownership cannot be expressed without Clone on // the trait object. - // TODO(human-review): returning a shared style here needs an Rc/Clone strategy in Phase C. + // TODO(phase-c): returning a shared style here needs an Rc/Clone strategy in Phase C. let _ = &self.styles[&shirabe_php_shim::strtolower(name)]; todo!() } diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/table.rs b/crates/shirabe-external-packages/src/symfony/console/helper/table.rs index 99c1b6ea..42c920f6 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/table.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/table.rs @@ -465,7 +465,7 @@ impl Table { } if self.rendered { - // TODO(phase-b): downcast output to ConsoleSectionOutput to call clear(). + // TODO(phase-c): downcast output to ConsoleSectionOutput to call clear(). let _ = ConsoleSectionOutput::clear; let row_count = self.calculate_row_count(); let _ = row_count; @@ -482,7 +482,7 @@ impl Table { // PHP indexes $this->rows by arbitrary key; sparse assignment over a positional Vec is not // modeled and has no callers. let _ = (column, row); - // TODO(phase-d): sparse `$this->rows[$column] = $row` over a positional row vector. + // TODO(phase-c): sparse `$this->rows[$column] = $row` over a positional row vector. todo!() } diff --git a/crates/shirabe-external-packages/src/symfony/finder/spl_file_info.rs b/crates/shirabe-external-packages/src/symfony/finder/spl_file_info.rs index c1d158dd..6f03fe14 100644 --- a/crates/shirabe-external-packages/src/symfony/finder/spl_file_info.rs +++ b/crates/shirabe-external-packages/src/symfony/finder/spl_file_info.rs @@ -78,7 +78,7 @@ impl SplFileInfo { pub fn get_size(&self) -> i64 { // \SplFileInfo::getSize() returns the file size in bytes (throws on failure). - // TODO(phase-d): PHP throws a \RuntimeException on stat failure; this returns 0 instead. + // TODO(phase-c): PHP throws a \RuntimeException on stat failure; this returns 0 instead. shirabe_php_shim::filesize(&self.pathname).unwrap_or(0) } } diff --git a/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs b/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs index e4158466..9048f77b 100644 --- a/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs +++ b/crates/shirabe-external-packages/src/symfony/string/unicode_string.rs @@ -34,7 +34,7 @@ impl UnicodeString { width } - // TODO(phase-d): the faithful `length()` uses `grapheme_strlen` (extended grapheme clusters), + // TODO(phase-c): the faithful `length()` uses `grapheme_strlen` (extended grapheme clusters), // which needs Unicode segmentation tables with no Rust std equivalent and no permitted crate. // Approximated with the code-point count, exact only when no combining/multi-code-point // clusters are present (e.g. ASCII). @@ -42,7 +42,7 @@ impl UnicodeString { shirabe_php_shim::mb_strlen(&self.string, "UTF-8") } - // TODO(phase-d): the faithful `slice()` uses `grapheme_substr` (grapheme-cluster offsets), which + // TODO(phase-c): the faithful `slice()` uses `grapheme_substr` (grapheme-cluster offsets), which // needs Unicode segmentation tables with no std equivalent and no permitted crate. Approximated // with code-point offsets via `mb_substr`, exact only without combining/multi-code-point clusters. pub fn slice(&self, start: i64, length: Option<i64>) -> Self { |