aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-symfony-process/src
diff options
context:
space:
mode:
Diffstat (limited to 'crates/shirabe-symfony-process/src')
-rw-r--r--crates/shirabe-symfony-process/src/pipes/abstract_pipes.rs3
1 files changed, 3 insertions, 0 deletions
diff --git a/crates/shirabe-symfony-process/src/pipes/abstract_pipes.rs b/crates/shirabe-symfony-process/src/pipes/abstract_pipes.rs
index 8741926c..f7269eb3 100644
--- a/crates/shirabe-symfony-process/src/pipes/abstract_pipes.rs
+++ b/crates/shirabe-symfony-process/src/pipes/abstract_pipes.rs
@@ -44,6 +44,9 @@ impl AbstractPipes {
}
/// Returns true if a system call has been interrupted.
+ // TODO(php-runtime): `last_error` is never set. PHP fills it from a `set_error_handler` wrapped
+ // around `stream_select`, so this always reports false and an EINTR-interrupted `select` resets
+ // the pipes instead of being retried.
pub(crate) fn has_system_call_been_interrupted(&mut self) -> bool {
let last_error = self.last_error.take();