aboutsummaryrefslogtreecommitdiffhomepage
path: root/crates/shirabe-symfony-process/src/process.rs
AgeCommit message (Collapse)Author
2026-08-10refactor(symfony-process): drop the --enable-sigchild workaroundsnsfisis
isSigchildEnabled() detects a PHP built with --enable-sigchild, where PHP reaps children itself and proc_get_status()/proc_terminate() stop reporting or reaching them. Shirabe spawns child processes from Rust, so that build option cannot affect them and every sigchild branch was unreachable. Removing the branches retires the state that existed only to feed them: fallbackStatus (written by the fourth pipe and by doSignal, read only by the sigchild merge in updateStatus) and useFileHandles (whose sole reader was the sigchild condition). shirabe-php-shim loses phpinfo(), INFO_GENERAL and posix_kill(), which had no other callers. DiagnoseCommand keeps its --enable-sigchild warning: it reports on the user's PHP installation, not on how Shirabe runs processes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-10refactor(symfony): hide leaf modules behind their parent re-exportsnsfisis
Every parent module in the symfony-* crates already re-exported its leaf modules with `pub use`, so each item was reachable by two paths. Make the leaf modules private and route all callers through the single re-exported path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-09refactor(symfony-process): extract symfony/process into the ↵nsfisis
shirabe-symfony-process crate Move `Symfony\Component\Process` out of shirabe-external-packages and into its own crate, so the path is `shirabe_symfony_process::Process` instead of `shirabe_external_packages::symfony::process::Process`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>