From 0abd0141380aa491ad6e65c58979e2fa371e3df0 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 03:06:16 +0900 Subject: feat(dependency-resolver): delegate get_operations to inner transaction Resolve TODO(phase-b) in LocalRepoTransaction. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/dependency_resolver/local_repo_transaction.rs | 8 +++----- crates/shirabe/src/dependency_resolver/transaction.rs | 1 - crates/shirabe/src/installer.rs | 2 +- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs b/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs index 5feb9eb..eb77add 100644 --- a/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs +++ b/crates/shirabe/src/dependency_resolver/local_repo_transaction.rs @@ -1,6 +1,7 @@ //! ref: composer/src/Composer/DependencyResolver/LocalRepoTransaction.php use super::Transaction; +use crate::dependency_resolver::operation::OperationInterface; use crate::repository::InstalledRepositoryInterface; use crate::repository::RepositoryInterface; @@ -22,10 +23,7 @@ impl LocalRepoTransaction { }) } - pub fn get_operations( - &self, - ) -> Vec> { - // TODO(phase-b): delegate to inner transaction once operations are typed. - Vec::new() + pub fn get_operations(&self) -> &Vec> { + self.inner.get_operations() } } diff --git a/crates/shirabe/src/dependency_resolver/transaction.rs b/crates/shirabe/src/dependency_resolver/transaction.rs index a693356..874085f 100644 --- a/crates/shirabe/src/dependency_resolver/transaction.rs +++ b/crates/shirabe/src/dependency_resolver/transaction.rs @@ -62,7 +62,6 @@ impl Transaction { this } - /// @return OperationInterface[] pub fn get_operations(&self) -> &Vec> { &self.operations } diff --git a/crates/shirabe/src/installer.rs b/crates/shirabe/src/installer.rs index faa34fb..3ab88c2 100644 --- a/crates/shirabe/src/installer.rs +++ b/crates/shirabe/src/installer.rs @@ -1214,7 +1214,7 @@ impl Installer { local_repo_ref .as_installed_repository_interface_mut() .unwrap(), - local_repo_transaction.get_operations(), + local_repo_transaction.get_operations().clone(), self.dev_mode, self.run_scripts, self.download_only, -- cgit v1.3.1