From 230319ae3db47ed9c35dc7faa733a84f9ce87ff9 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 25 Jun 2026 14:50:26 +0900 Subject: test: un-ignore tests unblocked by zip/spdx/jsonlint/stream impls Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/json/json_file_test.rs | 2 -- crates/shirabe/tests/platform/hhvm_detector_test.rs | 1 - crates/shirabe/tests/util/config_validator_test.rs | 3 --- crates/shirabe/tests/util/stream_context_factory_test.rs | 1 - crates/shirabe/tests/util/zip_test.rs | 8 -------- 5 files changed, 15 deletions(-) diff --git a/crates/shirabe/tests/json/json_file_test.rs b/crates/shirabe/tests/json/json_file_test.rs index aea34ba..cd4445c 100644 --- a/crates/shirabe/tests/json/json_file_test.rs +++ b/crates/shirabe/tests/json/json_file_test.rs @@ -503,7 +503,6 @@ fn test_composer_lock_file_merge_conflict_simple_crlf() { } #[test] -#[ignore] fn test_composer_lock_file_merge_conflict_complex() { // complex files have multiple conflict markers and can thus not be simply resolved let data = @@ -514,7 +513,6 @@ fn test_composer_lock_file_merge_conflict_complex() { } #[test] -#[ignore] fn test_composer_lock_file_merge_conflict_complex_crlf() { // complex files have multiple conflict markers and can thus not be simply resolved let data = std::fs::read_to_string(fixture_path( diff --git a/crates/shirabe/tests/platform/hhvm_detector_test.rs b/crates/shirabe/tests/platform/hhvm_detector_test.rs index 7347bf7..71da314 100644 --- a/crates/shirabe/tests/platform/hhvm_detector_test.rs +++ b/crates/shirabe/tests/platform/hhvm_detector_test.rs @@ -24,7 +24,6 @@ fn test_hhvm_version_when_executing_in_hhvm() { assert_eq!(version_id_to_version(), version); } -#[ignore] #[test] fn test_hhvm_version_when_executing_in_php() { let mut hhvm_detector = set_up(); diff --git a/crates/shirabe/tests/util/config_validator_test.rs b/crates/shirabe/tests/util/config_validator_test.rs index 2e4aed0..4f25535 100644 --- a/crates/shirabe/tests/util/config_validator_test.rs +++ b/crates/shirabe/tests/util/config_validator_test.rs @@ -29,7 +29,6 @@ fn validate(file: &str) -> Vec { /// Test ConfigValidator warns on commit reference #[test] -#[ignore] fn test_config_validator_commit_ref_warning() { let warnings = validate(&fixture("composer_commit-ref.json")); @@ -39,7 +38,6 @@ fn test_config_validator_commit_ref_warning() { } #[test] -#[ignore] fn test_config_validator_warns_on_script_description_for_nonexistent_script() { let warnings = validate(&fixture("composer_scripts-descriptions.json")); @@ -52,7 +50,6 @@ fn test_config_validator_warns_on_script_description_for_nonexistent_script() { } #[test] -#[ignore] fn test_config_validator_warns_on_script_alias_for_nonexistent_script() { let warnings = validate(&fixture("composer_scripts-aliases.json")); diff --git a/crates/shirabe/tests/util/stream_context_factory_test.rs b/crates/shirabe/tests/util/stream_context_factory_test.rs index 6491883..ad123aa 100644 --- a/crates/shirabe/tests/util/stream_context_factory_test.rs +++ b/crates/shirabe/tests/util/stream_context_factory_test.rs @@ -339,7 +339,6 @@ fn test_ssl_proxy() { } #[test] -#[ignore] fn test_ensure_thatfix_http_header_field_moves_content_type_to_end_of_options() { let _tear_down = TearDown; set_up(); diff --git a/crates/shirabe/tests/util/zip_test.rs b/crates/shirabe/tests/util/zip_test.rs index 4d883e0..0c7d96a 100644 --- a/crates/shirabe/tests/util/zip_test.rs +++ b/crates/shirabe/tests/util/zip_test.rs @@ -18,7 +18,6 @@ fn test_throws_exception_if_zip_extension_is_not_loaded() { } #[test] -#[ignore] fn test_returns_nullif_the_zip_is_not_found() { let result = Zip::get_composer_json(&fixture("invalid.zip")).unwrap(); @@ -26,7 +25,6 @@ fn test_returns_nullif_the_zip_is_not_found() { } #[test] -#[ignore] fn test_returns_null_if_the_zip_is_empty() { let result = Zip::get_composer_json(&fixture("empty.zip")).unwrap(); @@ -34,19 +32,16 @@ fn test_returns_null_if_the_zip_is_empty() { } #[test] -#[ignore] fn test_throws_exception_if_the_zip_has_no_composer_json() { assert!(Zip::get_composer_json(&fixture("nojson.zip")).is_err()); } #[test] -#[ignore] fn test_throws_exception_if_the_composer_json_is_in_a_sub_subfolder() { assert!(Zip::get_composer_json(&fixture("subfolders.zip")).is_err()); } #[test] -#[ignore] fn test_returns_composer_json_in_zip_root() { let result = Zip::get_composer_json(&fixture("root.zip")).unwrap(); @@ -57,7 +52,6 @@ fn test_returns_composer_json_in_zip_root() { } #[test] -#[ignore] fn test_returns_composer_json_in_first_folder() { let result = Zip::get_composer_json(&fixture("folder.zip")).unwrap(); @@ -68,13 +62,11 @@ fn test_returns_composer_json_in_first_folder() { } #[test] -#[ignore] fn test_multiple_top_level_dirs_is_invalid() { assert!(Zip::get_composer_json(&fixture("multiple.zip")).is_err()); } #[test] -#[ignore] fn test_returns_composer_json_from_first_subfolder() { let result = Zip::get_composer_json(&fixture("single-sub.zip")).unwrap(); -- cgit v1.3.1