From 335c9c079b9215beb509bc298719733057aafd03 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 06:28:45 +0900 Subject: test(platform-repository): name real test_library_information blockers The previous ignore reason blamed unmodeled extension info; the actual blockers are the TODO(plugin) stubs resource_bundle_get (returns Null, dropping lib-icu-cldr) and imagick_get_version_string (returns "", dropping lib-imagick-imagemagick), both pending dynamic method dispatch on PHP objects via the plugin RPC mechanism. Co-Authored-By: Claude Fable 5 --- crates/shirabe/tests/repository/platform_repository_test.rs | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/crates/shirabe/tests/repository/platform_repository_test.rs b/crates/shirabe/tests/repository/platform_repository_test.rs index 83edf635..507938a0 100644 --- a/crates/shirabe/tests/repository/platform_repository_test.rs +++ b/crates/shirabe/tests/repository/platform_repository_test.rs @@ -1612,11 +1612,16 @@ fn assert_package_links( } } +// TODO(phase-d): blocked by the TODO(plugin) stubs below; re-check once the plugin RPC +// mechanism can dispatch method calls on PHP objects. #[test] -#[ignore = "all 59 provideLibraryTestCases datasets ported faithfully; several cases rely on \ - ResourceBundle/Imagick-derived extension info (e.g. lib-icu-cldr) that is not yet \ - modeled, so the generated package set diverges from PHP's (confirmed: fails with \ - an extension mismatch, not a panic), and it stays ignored"] +#[ignore = "all 59 provideLibraryTestCases datasets ported faithfully; blocked by two \ + TODO(plugin) stubs in PlatformRepository that need dynamic method dispatch on \ + PHP objects ($resourceBundle->get('Version'), $imagick->getVersion()): \ + resource_bundle_get returns Null so the intl dataset drops lib-icu-cldr, and \ + imagick_get_version_string returns \"\" so the imagick datasets drop \ + lib-imagick-imagemagick (confirmed current failure mode: package-set mismatch \ + on the intl dataset, not a panic)"] fn test_library_information() { let extension_version = "100.200.300"; -- cgit v1.3.1