From 3ff81cbade26a5de4e67076854e59b16a270140b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 4 Jul 2026 19:33:55 +0900 Subject: fix(platform-repository): avoid infinite recursion in addOverriddenPackage PHP's addOverriddenPackage calls parent::addPackage() (a non-virtual call straight to ArrayRepository), but the port called self.add_package, re-entering PlatformRepository::add_package. Since the newly created override package's name also starts with "php-", this recursed forever and blew the stack. --- crates/shirabe/src/repository/platform_repository.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/shirabe/src/repository/platform_repository.rs b/crates/shirabe/src/repository/platform_repository.rs index 9dffe66..73c4dbe 100644 --- a/crates/shirabe/src/repository/platform_repository.rs +++ b/crates/shirabe/src/repository/platform_repository.rs @@ -1600,7 +1600,7 @@ impl PlatformRepository { extra.insert("config.platform".to_string(), PhpMixed::Bool(true)); package.inner.set_extra(extra); let package = CompletePackageHandle::from_complete_package(package); - self.add_package(package.clone().into())?; + self.inner.add_package(package.clone().into())?; if package.get_name() == "php" { let parts = explode(".", &package.get_version()); -- cgit v1.3.1