From 41de0d502e76c0054f2b4dd0bd73ef3086ed5fbe Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 4 Jul 2026 22:43:25 +0900 Subject: fix(cache): gate "reading/writing ... cache" messages behind debug verbosity Cache::read/write/copy_to called write_error (always visible) instead of write_error3(.., IOInterface::DEBUG) like the PHP source, so these messages leaked into default-verbosity output instead of only showing under -vvv, producing extra lines not present in real Composer's output. --- crates/shirabe/src/cache.rs | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/crates/shirabe/src/cache.rs b/crates/shirabe/src/cache.rs index 87f6ea4..e203eb1 100644 --- a/crates/shirabe/src/cache.rs +++ b/crates/shirabe/src/cache.rs @@ -127,8 +127,11 @@ impl Cache { let file = Preg::replace(&format!("{{[^{}]}}i", self.allowlist), "-", file); let full_path = format!("{}{}", self.root, file); if file_exists(&full_path) { - self.io - .write_error(&format!("Reading {} from cache", full_path)); + self.io.write_error3( + &format!("Reading {} from cache", full_path), + true, + crate::io::DEBUG, + ); return file_get_contents(&full_path); } @@ -143,8 +146,11 @@ impl Cache { if self.is_enabled() && !self.read_only { let file = Preg::replace(&format!("{{[^{}]}}i", self.allowlist), "-", file); - self.io - .write_error(&format!("Writing {}{} into cache", self.root, file)); + self.io.write_error3( + &format!("Writing {}{} into cache", self.root, file), + true, + crate::io::DEBUG, + ); let temp_file_name = format!("{}{}{}.tmp", self.root, file, bin2hex(&random_bytes(5))); let dest = format!("{}{}", self.root, file); @@ -169,10 +175,14 @@ impl Cache { return self.write(&file, contents); } - self.io.write_error(&format!( - "Failed to write into cache: {}", - e.message, - )); + self.io.write_error3( + &format!( + "Failed to write into cache: {}", + e.message + ), + true, + crate::io::DEBUG, + ); let mut m = indexmap::IndexMap::new(); if Preg::match3( r"{^file_put_contents\(\): Only ([0-9]+) of ([0-9]+) bytes written}", @@ -263,8 +273,11 @@ impl Cache { } } - self.io - .write_error(&format!("Reading {} from cache", full_path)); + self.io.write_error3( + &format!("Reading {} from cache", full_path), + true, + crate::io::DEBUG, + ); return self.filesystem.borrow_mut().copy(&full_path, target); } -- cgit v1.3.1