From ff00c76d2033b0e3bc15aa3fa6e282d72b00cd1f Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 03:25:08 +0900 Subject: fix(xdebug-handler): implement get_all_ini_files for no-PHP-runtime case Without a PHP runtime no XdebugHandler is ever constructed, so the COMPOSER_ORIG_INIS lookup is skipped and php_ini_loaded_file() / php_ini_scanned_files() are both false; PHP would return [(string) false] = [""]. Model that directly instead of todo!(). Co-Authored-By: Claude Fable 5 --- .../src/composer/xdebug_handler/xdebug_handler.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'crates/shirabe-external-packages/src/composer') diff --git a/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs b/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs index 7390a8e6..01f8eb78 100644 --- a/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs +++ b/crates/shirabe-external-packages/src/composer/xdebug_handler/xdebug_handler.rs @@ -18,6 +18,11 @@ impl XdebugHandler { } pub fn get_all_ini_files() -> Vec { - todo!() + // TODO(php-runtime) + // No XdebugHandler is ever constructed (`self::$name` stays null) so the + // COMPOSER_ORIG_INIS env lookup is skipped, and without a PHP runtime + // `php_ini_loaded_file()` is `false` and `php_ini_scanned_files()` is `false`, + // so PHP would return `[(string) false]` = `[""]`. + vec![String::new()] } } -- cgit v1.3.1