From 981cae63d9777b877aa9f96907c7995ec020fbf9 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 12 Jun 2026 02:14:18 +0900 Subject: feat(php-shim): implement runtime functions to run --version Replace todo!() stubs reached on the `composer --version` path so the command runs without panicking and exits cleanly: - introspection (function_exists, class_exists, extension_loaded, defined) via white-lists modeling a standard Linux PHP CLI - type casts: php_to_string/strval, php_truthy/boolval, substr, byte_at, explode, strtr_array - config/env: error_reporting, ini_get, date_default_timezone_*, server_get/server_contains_key, php_uname("s") - IO: turn PhpResource into an enum (Stdin/Stdout/Stderr/File) and implement fwrite/fflush/stream_isatty/php_fopen resource helpers - shutdown/exit: register_shutdown_function + run_shutdown_functions, exit, error_get_last - preg_match_all_offset_capture via the regex crate; the formatter pattern drops PCRE possessive quantifiers (original kept in a comment with a TODO) proc_open reports unavailable for now (TODO(phase-c)); terminal-size and tty detection fall back to defaults. sprintf calls on this path are rewritten with format!(). OutputFormatterStyleInterface gains clone_box to return shared styles. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../shirabe-external-packages/src/symfony/console/application.rs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/application.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/application.rs b/crates/shirabe-external-packages/src/symfony/console/application.rs index 83309f4..e15b68d 100644 --- a/crates/shirabe-external-packages/src/symfony/console/application.rs +++ b/crates/shirabe-external-packages/src/symfony/console/application.rs @@ -546,13 +546,7 @@ impl Application { pub fn get_long_version(&self) -> String { if "UNKNOWN" != self.get_name() { if "UNKNOWN" != self.get_version() { - return shirabe_php_shim::sprintf( - "%s %s", - &[ - PhpMixed::from(self.get_name()), - PhpMixed::from(self.get_version()), - ], - ); + return format!("{} {}", self.get_name(), self.get_version()); } return self.get_name(); -- cgit v1.3.1