From 69c372ba0eca61b05260d6d208445d9e69d14e34 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 13 Jun 2026 11:38:20 +0900
Subject: fix(console): flatten Application inheritance to restore overrides

Composer\Console\Application embedded Symfony's Application as an
`inner` field and delegated to it, so polymorphic calls inside the
Symfony base (e.g. doRun -> $this->getLongVersion()) resolved to
Symfony's own methods and never reached Composer's overrides. As a
result `--version` bypassed Composer's getLongVersion()/doRun()
entirely.

Flatten the PHP inheritance chain into the single shirabe Application
struct: take in the Symfony base methods (parent-calling overrides kept
under a `base_` prefix) and drop the `inner` delegation. Replace the
Symfony Application struct in shirabe-external-packages with an
`Application` trait that the merged struct implements, so commands and
descriptors can reference it without a reverse crate dependency.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../src/symfony/console/command/dump_completion_command.rs            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs')

diff --git a/crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs b/crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs
index 51287c7..1929c64 100644
--- a/crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs
@@ -230,14 +230,14 @@ impl Command for DumpCompletionCommand {
 
     fn set_application(
         &mut self,
-        application: Option<Rc<RefCell<crate::symfony::console::application::Application>>>,
+        application: Option<Rc<RefCell<dyn crate::symfony::console::application::Application>>>,
     ) {
         self.inner.set_application(application);
     }
 
     fn get_application(
         &self,
-    ) -> Option<Rc<RefCell<crate::symfony::console::application::Application>>> {
+    ) -> Option<Rc<RefCell<dyn crate::symfony::console::application::Application>>> {
         self.inner.get_application()
     }
 
-- 
cgit v1.3.1