From f1af14b1cc503ac20f56a79a96c7780d02bdfe75 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Wed, 24 Jun 2026 03:56:26 +0900
Subject: fix(console): make Command/BaseCommand methods take &self

The Command trait and Composer's BaseCommand took &mut self, so dispatch
held a borrow_mut on the command's RefCell for the whole call. A command
re-entering itself (e.g. the help command describing itself) then panicked
with "RefCell already borrowed".

All Command/BaseCommand methods now take &self and the command state is
interior-mutable (Cell/RefCell). Shared borrows coexist, so re-entrant
describe paths no longer conflict. Getters that returned references now
return Ref guards; the descriptor describe_* methods take &dyn Command;
mixin accessors return Ref/RefMut.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../src/symfony/console/command/dump_completion_command.rs          | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs')

diff --git a/crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs b/crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs
index cb76ff8..306bd59 100644
--- a/crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/command/dump_completion_command.rs
@@ -45,7 +45,7 @@ impl DumpCompletionCommand {
     pub const DEFAULT_DESCRIPTION: &'static str = "Dump the shell completion script";
 
     pub fn new() -> Self {
-        let mut command = DumpCompletionCommand {
+        let command = DumpCompletionCommand {
             inner: CommandData::new(None),
         };
         // PHP: static $defaultName = 'completion' / $defaultDescription, applied by the parent
@@ -111,7 +111,7 @@ impl DumpCompletionCommand {
 }
 
 impl Command for DumpCompletionCommand {
-    fn configure(&mut self) -> anyhow::Result<()> {
+    fn configure(&self) -> anyhow::Result<()> {
         let full_command = shirabe_php_shim::server_php_self();
         let command_name = shirabe_php_shim::basename(&full_command);
         // @realpath($fullCommand) ?: $fullCommand
@@ -166,7 +166,7 @@ impl Command for DumpCompletionCommand {
     }
 
     fn execute(
-        &mut self,
+        &self,
         input: Rc<RefCell<dyn InputInterface>>,
         output: Rc<RefCell<dyn OutputInterface>>,
     ) -> anyhow::Result<i64> {
-- 
cgit v1.3.1