From f1af14b1cc503ac20f56a79a96c7780d02bdfe75 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 24 Jun 2026 03:56:26 +0900 Subject: fix(console): make Command/BaseCommand methods take &self The Command trait and Composer's BaseCommand took &mut self, so dispatch held a borrow_mut on the command's RefCell for the whole call. A command re-entering itself (e.g. the help command describing itself) then panicked with "RefCell already borrowed". All Command/BaseCommand methods now take &self and the command state is interior-mutable (Cell/RefCell). Shared borrows coexist, so re-entrant describe paths no longer conflict. Getters that returned references now return Ref guards; the descriptor describe_* methods take &dyn Command; mixin accessors return Ref/RefMut. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../src/symfony/console/descriptor/descriptor.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/descriptor/descriptor.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/descriptor/descriptor.rs b/crates/shirabe-external-packages/src/symfony/console/descriptor/descriptor.rs index 38824a6..5055b49 100644 --- a/crates/shirabe-external-packages/src/symfony/console/descriptor/descriptor.rs +++ b/crates/shirabe-external-packages/src/symfony/console/descriptor/descriptor.rs @@ -39,7 +39,7 @@ pub trait Descriptor: DescriptorInterface { self.describe_input_definition(&definition, options)?; } DescribableObject::Command(command) => { - self.describe_command(&mut *command.borrow_mut(), options)?; + self.describe_command(&*command.borrow(), options)?; } DescribableObject::Application(application) => { self.describe_application(application, options)?; @@ -86,7 +86,7 @@ pub trait Descriptor: DescriptorInterface { /// Describes a Command instance. fn describe_command( &mut self, - command: &mut dyn Command, + command: &dyn Command, options: IndexMap, ) -> anyhow::Result<()>; -- cgit v1.3.1