From efe5bdb1987411a473d4af15451a376d20928245 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 12 Jun 2026 03:19:34 +0900 Subject: refactor(php-shim): replace literal sprintf calls with format! Convert every sprintf() call with a compile-time literal format string to format!, implementing Display for PhpMixed (delegating to php_to_string) so PhpMixed values render with PHP string semantics through {}. Also merge the format!-wrapped and conditional-literal dynamic sites into single format! calls. Genuinely runtime format strings (table styles, configurable error messages, command synopsis, progress-bar modifiers, regex-built messages) still go through sprintf. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../console/descriptor/markdown_descriptor.rs | 36 ++++++++++------------ 1 file changed, 16 insertions(+), 20 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs b/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs index 5ec5c95..1fec085 100644 --- a/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs +++ b/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs @@ -256,20 +256,18 @@ impl MarkdownDescriptor { &command_names .iter() .map(|command_name| { - Ok(shirabe_php_shim::sprintf( - "* [`%s`](#%s)", - &[ - PhpMixed::String(command_name.clone()), - PhpMixed::String(shirabe_php_shim::str_replace( - ":", - "", - &description - .get_command(command_name)? - .borrow() - .get_name() - .unwrap_or_default(), - )), - ], + Ok(format!( + "* [`{}`](#{})", + PhpMixed::String(command_name.clone()), + PhpMixed::String(shirabe_php_shim::str_replace( + ":", + "", + &description + .get_command(command_name)? + .borrow() + .get_name() + .unwrap_or_default(), + )), )) }) .collect::>>()? @@ -294,12 +292,10 @@ impl MarkdownDescriptor { fn get_application_title(&self, application: &Application) -> String { if "UNKNOWN" != application.get_name() { if "UNKNOWN" != application.get_version() { - return shirabe_php_shim::sprintf( - "%s %s", - &[ - PhpMixed::String(application.get_name()), - PhpMixed::String(application.get_version()), - ], + return format!( + "{} {}", + PhpMixed::String(application.get_name()), + PhpMixed::String(application.get_version()), ); } -- cgit v1.3.1