From f1af14b1cc503ac20f56a79a96c7780d02bdfe75 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 24 Jun 2026 03:56:26 +0900 Subject: fix(console): make Command/BaseCommand methods take &self The Command trait and Composer's BaseCommand took &mut self, so dispatch held a borrow_mut on the command's RefCell for the whole call. A command re-entering itself (e.g. the help command describing itself) then panicked with "RefCell already borrowed". All Command/BaseCommand methods now take &self and the command state is interior-mutable (Cell/RefCell). Shared borrows coexist, so re-entrant describe paths no longer conflict. Getters that returned references now return Ref guards; the descriptor describe_* methods take &dyn Command; mixin accessors return Ref/RefMut. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../src/symfony/console/descriptor/markdown_descriptor.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs b/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs index 49d958f..ef16fc0 100644 --- a/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs +++ b/crates/shirabe-external-packages/src/symfony/console/descriptor/markdown_descriptor.rs @@ -147,7 +147,7 @@ impl MarkdownDescriptor { fn describe_command( &mut self, - command: &mut dyn Command, + command: &dyn Command, options: IndexMap, ) -> anyhow::Result<()> { if matches!(options.get("short"), Some(PhpMixed::Bool(true))) { @@ -285,10 +285,10 @@ impl MarkdownDescriptor { .values() .map(|c| c.borrow().clone_box()) .collect(); - for mut command in command_list { + for command in command_list { self.write("\n\n", true); // describeCommand returns null; the guarded write never runs. - self.describe_command(command.as_mut(), options.clone())?; + self.describe_command(command.as_ref(), options.clone())?; } Ok(()) } @@ -372,7 +372,7 @@ impl Descriptor for MarkdownDescriptor { fn describe_command( &mut self, - command: &mut dyn Command, + command: &dyn Command, options: IndexMap, ) -> anyhow::Result<()> { MarkdownDescriptor::describe_command(self, command, options) -- cgit v1.3.1