From efe5bdb1987411a473d4af15451a376d20928245 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 12 Jun 2026 03:19:34 +0900 Subject: refactor(php-shim): replace literal sprintf calls with format! Convert every sprintf() call with a compile-time literal format string to format!, implementing Display for PhpMixed (delegating to php_to_string) so PhpMixed values render with PHP string semantics through {}. Also merge the format!-wrapped and conditional-literal dynamic sites into single format! calls. Genuinely runtime format strings (table styles, configurable error messages, command synopsis, progress-bar modifiers, regex-built messages) still go through sprintf. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../src/symfony/console/helper/helper.rs | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/helper/helper.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/helper.rs b/crates/shirabe-external-packages/src/symfony/console/helper/helper.rs index b599f11..3122f82 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/helper.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/helper.rs @@ -110,31 +110,18 @@ impl Helper { pub fn format_memory(memory: i64) -> String { if memory >= 1024 * 1024 * 1024 { - return shirabe_php_shim::sprintf( - "%.1f GiB", - &[shirabe_php_shim::PhpMixed::Float( - memory as f64 / 1024.0 / 1024.0 / 1024.0, - )], - ); + return format!("{:.1} GiB", memory as f64 / 1024.0 / 1024.0 / 1024.0,); } if memory >= 1024 * 1024 { - return shirabe_php_shim::sprintf( - "%.1f MiB", - &[shirabe_php_shim::PhpMixed::Float( - memory as f64 / 1024.0 / 1024.0, - )], - ); + return format!("{:.1} MiB", memory as f64 / 1024.0 / 1024.0,); } if memory >= 1024 { - return shirabe_php_shim::sprintf( - "%d KiB", - &[shirabe_php_shim::PhpMixed::Int(memory / 1024)], - ); + return format!("{} KiB", shirabe_php_shim::PhpMixed::Int(memory / 1024),); } - shirabe_php_shim::sprintf("%d B", &[shirabe_php_shim::PhpMixed::Int(memory)]) + format!("{} B", shirabe_php_shim::PhpMixed::Int(memory)) } /// @deprecated since Symfony 5.3 -- cgit v1.3.1