From f4cad2123b2af0de72bda4ce039e16e74f163f4e Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 8 Aug 2026 22:14:12 +0900 Subject: feat(php-shim): give ported exceptions PHP's class hierarchy Ported exceptions were flat structs reached with `downcast_ref`, so Composer's `catch (\RuntimeException $e)` only matched the exact leaf type and `get_class($e)` had nothing to report. Each exception now embeds an instance of the class it extends and travels inside an `AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and `PhpClass::php_class_name` yields the PHP FQCN. Dropping the `std::error::Error` impls from the exception types leaves `AnyThrowable` as the only route into an `anyhow::Error`, so the walk cannot be bypassed. A `no_exception_downcast` linter catches the `downcast::()` calls that would now silently answer `None`. Three sites change behavior as a result: the `TransportException` exit-code override reaches `MaxFileSizeExceededException`, the `catch (\LogicException)` in findSimilar() reaches its subclasses, and rendered exception titles carry the real class name rather than a guess. `get_class_err()` is no longer a `todo!()`, which re-enables FilesystemRepositoryTest::testCorruptedRepositoryFile. Co-Authored-By: Claude Opus 5 (1M context) --- .../src/symfony/console/helper/progress_bar.rs | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/helper/progress_bar.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/progress_bar.rs b/crates/shirabe-external-packages/src/symfony/console/helper/progress_bar.rs index 0abee1e7..7bfbfbcd 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/progress_bar.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/progress_bar.rs @@ -642,10 +642,7 @@ impl ProgressBar { "remaining".to_string(), Box::new(|bar: &ProgressBar, _output: &std::rc::Rc>| { if bar.get_max_steps() == 0 { - return Ok(Err(LogicException(shirabe_php_shim::LogicException { - message: "Unable to display the remaining time if the maximum number of steps is not set.".to_string(), - code: 0, - }))); + return Ok(Err(LogicException::new("Unable to display the remaining time if the maximum number of steps is not set.".to_string()))); } Ok(Ok(shirabe_php_shim::PhpMixed::String( @@ -658,10 +655,7 @@ impl ProgressBar { "estimated".to_string(), Box::new(|bar: &ProgressBar, _output: &std::rc::Rc>| { if bar.get_max_steps() == 0 { - return Ok(Err(LogicException(shirabe_php_shim::LogicException { - message: "Unable to display the estimated time if the maximum number of steps is not set.".to_string(), - code: 0, - }))); + return Ok(Err(LogicException::new("Unable to display the estimated time if the maximum number of steps is not set.".to_string()))); } Ok(Ok(shirabe_php_shim::PhpMixed::String( @@ -814,10 +808,7 @@ impl ProgressBar { let formatter = formatters.as_ref().unwrap().get(&name).unwrap(); formatter(self, &self.output) }); - match formatter_result? { - Ok(text) => text, - Err(e) => return Err(anyhow::Error::new(e)), - } + formatter_result?? } else if let Some(message) = self.messages.get(&name) { shirabe_php_shim::PhpMixed::String(message.clone()) } else { -- cgit v1.3.1-4-g156e