From efe5bdb1987411a473d4af15451a376d20928245 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 12 Jun 2026 03:19:34 +0900 Subject: refactor(php-shim): replace literal sprintf calls with format! Convert every sprintf() call with a compile-time literal format string to format!, implementing Display for PhpMixed (delegating to php_to_string) so PhpMixed values render with PHP string semantics through {}. Also merge the format!-wrapped and conditional-literal dynamic sites into single format! calls. Genuinely runtime format strings (table styles, configurable error messages, command synopsis, progress-bar modifiers, regex-built messages) still go through sprintf. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../src/symfony/console/helper/question_helper.rs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs b/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs index 7ddb620..dcd761c 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs @@ -301,9 +301,10 @@ impl QuestionHelper { let padding = shirabe_php_shim::str_repeat(" ", (max_width - Helper::width(key)) as usize); - messages.push(shirabe_php_shim::sprintf( - &format!(" [<{tag}>%s{padding}] %s"), - &[PhpMixed::String(key.clone()), (**value).clone()], + messages.push(format!( + " [<{tag}>{}{padding}] {}", + PhpMixed::String(key.clone()), + (**value).clone(), )); } -- cgit v1.3.1