From cbb5118318706dc023eb8551b1f2628f395a6228 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Fri, 26 Jun 2026 01:55:03 +0900
Subject: refactor(symfony-table): model rows/cells with enums instead of
 PhpMixed

The Table helper modeled a row's cells as PhpMixed and recovered the concrete
TableCell/TableSeparator types via runtime instance_of, leaving the entire
mixed/array bridge (to_row_vec, cell_colspan, row_get, ...) as todo!(). Replace
that with proper Row/Cell enums:

  Row  = HeaderDivider | Separator(TableSeparator) | Cells(Vec<Cell>)
  Cell = Null | Value(String) | Cell(TableCell) | Separator(TableSeparator)

The internal header/body boundary that PHP detects by object identity
($divider === $row) becomes the dedicated Row::HeaderDivider variant. Style
arguments (PHP string|TableStyle) become a StyleName enum, so Table::new no
longer panics in resolve_style's instance_of stub; TableStyle derives Clone so
named styles resolve from the registry.

PhpMixed-based callers (SymfonyStyle::table, render_table, auditor's sanitize)
bridge via From<PhpMixed> for Cell/Row at the boundary.

Un-ignores LicensesCommandTest text-format cases (4) and
BaseDependencyCommandTest::why; output matches PHP exactly. Removes ~15 impl
todo!()s in the Table helper.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 .../src/symfony/console/helper/table_separator.rs        | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

(limited to 'crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs')

diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs b/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs
index bb789f2..34626cc 100644
--- a/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/helper/table_separator.rs
@@ -22,6 +22,22 @@ impl TableSeparator {
             inner: TableCell::new("", options)?,
         })
     }
+
+    // PHP `TableSeparator extends TableCell`, so these inherited accessors remain available.
+    pub fn get_colspan(&self) -> i64 {
+        self.inner.get_colspan()
+    }
+
+    pub fn get_rowspan(&self) -> i64 {
+        self.inner.get_rowspan()
+    }
+
+    pub fn get_style(
+        &self,
+    ) -> Option<std::rc::Rc<crate::symfony::console::helper::table_cell_style::TableCellStyle>>
+    {
+        self.inner.get_style()
+    }
 }
 
 impl Default for TableSeparator {
-- 
cgit v1.3.1