From efec43b3b8827820cf35fe1b73d8e33f5fe84eb4 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 01:16:50 +0900 Subject: refactor: auto-fix clippy warnings --- .../src/symfony/console/helper/process_helper.rs | 6 ++++-- .../src/symfony/console/helper/question_helper.rs | 10 ++++++---- .../src/symfony/console/helper/table_cell.rs | 5 ----- 3 files changed, 10 insertions(+), 11 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/helper') diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs b/crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs index 1fad8f8..a32c95d 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/process_helper.rs @@ -149,11 +149,13 @@ impl ProcessHelper { .write(&[stopped], false, output_interface::OUTPUT_NORMAL); } - if !process.is_successful() && error.is_some() { + if !process.is_successful() + && let Some(error) = error + { output.borrow().writeln( &[format!( "{}", - shirabe_php_shim::PhpMixed::String(self.escape_string(error.unwrap()),), + shirabe_php_shim::PhpMixed::String(self.escape_string(error),), )], output_interface::OUTPUT_NORMAL, ); diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs b/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs index 3b91f3b..1c01d70 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/question_helper.rs @@ -465,7 +465,7 @@ impl QuestionHelper { None, ); output.borrow().write( - &[remaining_characters.clone()], + std::slice::from_ref(&remaining_characters), false, output_interface::OUTPUT_NORMAL, ); @@ -518,9 +518,11 @@ impl QuestionHelper { } let cur = c.clone().unwrap_or_default(); - output - .borrow() - .write(&[cur.clone()], false, output_interface::OUTPUT_NORMAL); + output.borrow().write( + std::slice::from_ref(&cur), + false, + output_interface::OUTPUT_NORMAL, + ); ret.push_str(&cur); full_choice.push_str(&cur); i += 1; diff --git a/crates/shirabe-external-packages/src/symfony/console/helper/table_cell.rs b/crates/shirabe-external-packages/src/symfony/console/helper/table_cell.rs index b737cbc..a967d0e 100644 --- a/crates/shirabe-external-packages/src/symfony/console/helper/table_cell.rs +++ b/crates/shirabe-external-packages/src/symfony/console/helper/table_cell.rs @@ -78,11 +78,6 @@ impl TableCell { Self::new(value, options).expect("TableCell options built internally are always valid") } - /// Returns the cell value. - pub fn to_string(&self) -> String { - self.value.clone() - } - /// Gets number of colspan. pub fn get_colspan(&self) -> i64 { match self.options["colspan"] { -- cgit v1.3.1