From f4cad2123b2af0de72bda4ce039e16e74f163f4e Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 8 Aug 2026 22:14:12 +0900
Subject: feat(php-shim): give ported exceptions PHP's class hierarchy

Ported exceptions were flat structs reached with `downcast_ref`, so
Composer's `catch (\RuntimeException $e)` only matched the exact leaf
type and `get_class($e)` had nothing to report. Each exception now
embeds an instance of the class it extends and travels inside an
`AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and
`PhpClass::php_class_name` yields the PHP FQCN.

Dropping the `std::error::Error` impls from the exception types leaves
`AnyThrowable` as the only route into an `anyhow::Error`, so the walk
cannot be bypassed. A `no_exception_downcast` linter catches the
`downcast::<X>()` calls that would now silently answer `None`.

Three sites change behavior as a result: the `TransportException`
exit-code override reaches `MaxFileSizeExceededException`, the
`catch (\LogicException)` in findSimilar() reaches its subclasses, and
rendered exception titles carry the real class name rather than a
guess. `get_class_err()` is no longer a `todo!()`, which re-enables
FilesystemRepositoryTest::testCorruptedRepositoryFile.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 .../src/symfony/console/input/input_argument.rs    | 28 +++++++++-------------
 1 file changed, 11 insertions(+), 17 deletions(-)

(limited to 'crates/shirabe-external-packages/src/symfony/console/input/input_argument.rs')

diff --git a/crates/shirabe-external-packages/src/symfony/console/input/input_argument.rs b/crates/shirabe-external-packages/src/symfony/console/input/input_argument.rs
index 4a732bd8..35f62389 100644
--- a/crates/shirabe-external-packages/src/symfony/console/input/input_argument.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/input/input_argument.rs
@@ -26,13 +26,11 @@ impl InputArgument {
         let mode = match mode {
             None => Self::OPTIONAL,
             Some(m) if !(1..=7).contains(&m) => {
-                return Err(
-                    InvalidArgumentException(shirabe_php_shim::InvalidArgumentException {
-                        message: format!("Argument mode \"{}\" is not valid.", m),
-                        code: 0,
-                    })
-                    .into(),
-                );
+                return Err(InvalidArgumentException::new(format!(
+                    "Argument mode \"{}\" is not valid.",
+                    m
+                ))
+                .into());
             }
             Some(m) => m,
         };
@@ -63,11 +61,9 @@ impl InputArgument {
 
     pub fn set_default(&mut self, default: PhpMixed) -> anyhow::Result<()> {
         if self.is_required() && !matches!(default, PhpMixed::Null) {
-            return Err(LogicException(shirabe_php_shim::LogicException {
-                message: "Cannot set a default value except for InputArgument::OPTIONAL mode."
-                    .to_string(),
-                code: 0,
-            })
+            return Err(LogicException::new(
+                "Cannot set a default value except for InputArgument::OPTIONAL mode.".to_string(),
+            )
             .into());
         }
 
@@ -76,11 +72,9 @@ impl InputArgument {
                 PhpMixed::Null => PhpMixed::List(vec![]),
                 PhpMixed::List(_) => default,
                 _ => {
-                    return Err(LogicException(shirabe_php_shim::LogicException {
-                        message: "A default value for an array argument must be an array."
-                            .to_string(),
-                        code: 0,
-                    })
+                    return Err(LogicException::new(
+                        "A default value for an array argument must be an array.".to_string(),
+                    )
                     .into());
                 }
             }
-- 
cgit v1.3.1-4-g156e