From efe5bdb1987411a473d4af15451a376d20928245 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 12 Jun 2026 03:19:34 +0900 Subject: refactor(php-shim): replace literal sprintf calls with format! Convert every sprintf() call with a compile-time literal format string to format!, implementing Display for PhpMixed (delegating to php_to_string) so PhpMixed values render with PHP string semantics through {}. Also merge the format!-wrapped and conditional-literal dynamic sites into single format! calls. Genuinely runtime format strings (table styles, configurable error messages, command synopsis, progress-bar modifiers, regex-built messages) still go through sprintf. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../src/symfony/console/input/string_input.rs | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/input/string_input.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/input/string_input.rs b/crates/shirabe-external-packages/src/symfony/console/input/string_input.rs index aad1d86..bbc9e86 100644 --- a/crates/shirabe-external-packages/src/symfony/console/input/string_input.rs +++ b/crates/shirabe-external-packages/src/symfony/console/input/string_input.rs @@ -102,13 +102,9 @@ impl StringInput { // should never happen return Err( InvalidArgumentException(shirabe_php_shim::InvalidArgumentException { - message: shirabe_php_shim::sprintf( - "Unable to parse input near \"... %s ...\".", - &[PhpMixed::String(shirabe_php_shim::substr( - input, - cursor, - Some(10), - ))], + message: format!( + "Unable to parse input near \"... {} ...\".", + PhpMixed::String(shirabe_php_shim::substr(input, cursor, Some(10),)), ), code: 0, }) -- cgit v1.3.1