From f4cad2123b2af0de72bda4ce039e16e74f163f4e Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 8 Aug 2026 22:14:12 +0900
Subject: feat(php-shim): give ported exceptions PHP's class hierarchy

Ported exceptions were flat structs reached with `downcast_ref`, so
Composer's `catch (\RuntimeException $e)` only matched the exact leaf
type and `get_class($e)` had nothing to report. Each exception now
embeds an instance of the class it extends and travels inside an
`AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and
`PhpClass::php_class_name` yields the PHP FQCN.

Dropping the `std::error::Error` impls from the exception types leaves
`AnyThrowable` as the only route into an `anyhow::Error`, so the walk
cannot be bypassed. A `no_exception_downcast` linter catches the
`downcast::<X>()` calls that would now silently answer `None`.

Three sites change behavior as a result: the `TransportException`
exit-code override reaches `MaxFileSizeExceededException`, the
`catch (\LogicException)` in findSimilar() reaches its subclasses, and
rendered exception titles carry the real class name rather than a
guess. `get_class_err()` is no longer a `todo!()`, which re-enables
FilesystemRepositoryTest::testCorruptedRepositoryFile.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 .../src/symfony/console/output/stream_output.rs            |  8 ++------
 .../src/symfony/console/output/trimmed_buffer_output.rs    | 14 ++++----------
 2 files changed, 6 insertions(+), 16 deletions(-)

(limited to 'crates/shirabe-external-packages/src/symfony/console/output')

diff --git a/crates/shirabe-external-packages/src/symfony/console/output/stream_output.rs b/crates/shirabe-external-packages/src/symfony/console/output/stream_output.rs
index 4d8eb921..9140dbc8 100644
--- a/crates/shirabe-external-packages/src/symfony/console/output/stream_output.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/output/stream_output.rs
@@ -37,12 +37,8 @@ impl StreamOutput {
         let verbosity = verbosity.unwrap_or(VERBOSITY_NORMAL);
 
         if shirabe_php_shim::get_resource_type(&stream) != "stream" {
-            return Ok(Err(InvalidArgumentException(
-                shirabe_php_shim::InvalidArgumentException {
-                    message: "The StreamOutput class needs a stream as its first argument."
-                        .to_string(),
-                    code: 0,
-                },
+            return Ok(Err(InvalidArgumentException::new(
+                "The StreamOutput class needs a stream as its first argument.".to_string(),
             )));
         }
 
diff --git a/crates/shirabe-external-packages/src/symfony/console/output/trimmed_buffer_output.rs b/crates/shirabe-external-packages/src/symfony/console/output/trimmed_buffer_output.rs
index b42f2a4e..4eb91b41 100644
--- a/crates/shirabe-external-packages/src/symfony/console/output/trimmed_buffer_output.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/output/trimmed_buffer_output.rs
@@ -21,16 +21,10 @@ impl TrimmedBufferOutput {
         formatter: Option<std::rc::Rc<std::cell::RefCell<dyn OutputFormatterInterface>>>,
     ) -> Result<Self, InvalidArgumentException> {
         if max_length <= 0 {
-            return Err(InvalidArgumentException(
-                shirabe_php_shim::InvalidArgumentException {
-                    message: format!(
-                        "\"{}()\" expects a strictly positive maxLength. Got {}.",
-                        "Symfony\\Component\\Console\\Output\\TrimmedBufferOutput::__construct",
-                        max_length,
-                    ),
-                    code: 0,
-                },
-            ));
+            return Err(InvalidArgumentException::new(format!(
+                "\"{}()\" expects a strictly positive maxLength. Got {}.",
+                "Symfony\\Component\\Console\\Output\\TrimmedBufferOutput::__construct", max_length,
+            )));
         }
 
         Ok(Self {
-- 
cgit v1.3.1-4-g156e