From d7c686f6c488739fc9d061bb0f89d73e6445fade Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 14 Jun 2026 13:08:21 +0900 Subject: refactor(pcre): return bool from preg_match shim preg_match can only return 1 or 0 now that compile failure panics, so return bool and update all call sites accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../src/symfony/console/question/choice_question.rs | 5 ++--- .../src/symfony/console/question/confirmation_question.rs | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/question') diff --git a/crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs b/crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs index 3990df3..9de2d05 100644 --- a/crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs +++ b/crates/shirabe-external-packages/src/symfony/console/question/choice_question.rs @@ -113,12 +113,11 @@ impl ChoiceQuestion { let selected_choices: Vec = if multiselect { // Check for a separated comma values let mut matches: Vec> = Vec::new(); - if shirabe_php_shim::preg_match( + if !shirabe_php_shim::preg_match( "/^[^,]+(?:,[^,]+)*$/", &shirabe_php_shim::strval(&selected), &mut matches, - ) == 0 - { + ) { return Err(InvalidArgumentException( shirabe_php_shim::InvalidArgumentException { message: shirabe_php_shim::sprintf(&error_message, &[selected.clone()]), diff --git a/crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs b/crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs index d52c435..5076d84 100644 --- a/crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs +++ b/crates/shirabe-external-packages/src/symfony/console/question/confirmation_question.rs @@ -42,7 +42,7 @@ impl ConfirmationQuestion { ®ex, &shirabe_php_shim::strval(&answer), &mut matches, - ) != 0 + ) }; // false === $default -- cgit v1.3.1