From 6dd09abb33d86e1aa737667f9e15a18ed41d52e1 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 9 Aug 2026 06:25:03 +0900 Subject: refactor(external-packages): test for Windows with cfg!(windows) MAIN_SEPARATOR is the path separator; PHP's `'\\' === DIRECTORY_SEPARATOR` uses it as an OS test only because PHP has no dedicated one. cfg!(windows) says what the branch actually selects on, and leaves MAIN_SEPARATOR to the sites that really join or split paths. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe-external-packages/src/symfony/console/terminal.rs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/terminal.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/terminal.rs b/crates/shirabe-external-packages/src/symfony/console/terminal.rs index 353dffcb..9af712ad 100644 --- a/crates/shirabe-external-packages/src/symfony/console/terminal.rs +++ b/crates/shirabe-external-packages/src/symfony/console/terminal.rs @@ -69,11 +69,7 @@ impl Terminal { let result = shirabe_php_shim::shell_exec(&format!( "stty 2> {}", - if std::path::MAIN_SEPARATOR == '\\' { - "NUL" - } else { - "/dev/null" - } + if cfg!(windows) { "NUL" } else { "/dev/null" } )) .is_some(); STTY.with(|s| s.set(Some(result))); @@ -81,7 +77,7 @@ impl Terminal { } fn init_dimensions() { - if std::path::MAIN_SEPARATOR == '\\' { + if cfg!(windows) { let ansicon = shirabe_php_shim::getenv("ANSICON"); let mut matches: Vec> = Vec::new(); if let Some(ansicon) = &ansicon -- cgit v1.3.1-4-g156e