From 81b9fc9d92bb74aa8428ae4db39bd84e8c16095c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 18:34:54 +0900 Subject: refactor(php-shim): drop Box wrapping from PhpMixed List/Array The List and Array variants of PhpMixed boxed their elements unnecessarily. Store PhpMixed values directly and update all callers accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../src/symfony/console/terminal.rs | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/console/terminal.rs') diff --git a/crates/shirabe-external-packages/src/symfony/console/terminal.rs b/crates/shirabe-external-packages/src/symfony/console/terminal.rs index 9ac1f9e..377d344 100644 --- a/crates/shirabe-external-packages/src/symfony/console/terminal.rs +++ b/crates/shirabe-external-packages/src/symfony/console/terminal.rs @@ -210,12 +210,12 @@ impl Terminal { let descriptorspec: Vec = vec![ PhpMixed::List(vec![ - Box::new(PhpMixed::String("pipe".to_string())), - Box::new(PhpMixed::String("w".to_string())), + PhpMixed::String("pipe".to_string()), + PhpMixed::String("w".to_string()), ]), PhpMixed::List(vec![ - Box::new(PhpMixed::String("pipe".to_string())), - Box::new(PhpMixed::String("w".to_string())), + PhpMixed::String("pipe".to_string()), + PhpMixed::String("w".to_string()), ]), ]; @@ -248,13 +248,10 @@ impl Terminal { /// Indexes into the `$pipes` array populated by proc_open. fn php_pipe(pipes: &PhpMixed, index: i64) -> PhpMixed { match pipes { - PhpMixed::List(list) => list - .get(index as usize) - .map(|v| (**v).clone()) - .unwrap_or(PhpMixed::Null), + PhpMixed::List(list) => list.get(index as usize).cloned().unwrap_or(PhpMixed::Null), PhpMixed::Array(array) => array .get(&index.to_string()) - .map(|v| (**v).clone()) + .map(|v| v.clone()) .unwrap_or(PhpMixed::Null), _ => PhpMixed::Null, } -- cgit v1.3.1