From 91692846909ed191addb7ec1c34aad11392ab88b Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 18 Jul 2026 15:03:55 +0900
Subject: perf(regex): eliminate per-call clone overhead in preg_* dispatch

regex::Regex::clone() does not share the underlying meta engine's
search-cache pool, so every fresh clone pays a ~10us warmup cost on
its first use. Two changes together eliminate this across nearly all
preg_* call sites:

- A php_regex! macro resolves PHP-style patterns to a per-call-site
  &'static regex::Regex (via regex-macro's LazyLock), applied at the
  majority of call sites throughout the codebase.
- Call sites still passing dynamic pattern strings go through
  PATTERN_CACHE, which now stores Arc<(Regex, bool)> and hands out
  Arc::clone()s instead of cloning the Regex itself.

PregPattern::resolve() returns a ResolvedPattern enum (Arc or
'static reference) rather than an owned Regex, so neither path ever
clones the Regex proper.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 .../shirabe-external-packages/src/symfony/console/terminal.rs  | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'crates/shirabe-external-packages/src/symfony/console/terminal.rs')

diff --git a/crates/shirabe-external-packages/src/symfony/console/terminal.rs b/crates/shirabe-external-packages/src/symfony/console/terminal.rs
index cc8f8128..7fca27e8 100644
--- a/crates/shirabe-external-packages/src/symfony/console/terminal.rs
+++ b/crates/shirabe-external-packages/src/symfony/console/terminal.rs
@@ -1,6 +1,6 @@
 //! ref: composer/vendor/symfony/console/Terminal.php
 
-use shirabe_php_shim::PhpMixed;
+use shirabe_php_shim::{PhpMixed, php_regex};
 use std::cell::Cell;
 
 thread_local! {
@@ -86,7 +86,7 @@ impl Terminal {
             let mut matches: Vec<Option<String>> = Vec::new();
             if let Some(ansicon) = &ansicon
                 && shirabe_php_shim::preg_match(
-                    "/^(\\d+)x(\\d+)(?: \\((\\d+)x(\\d+)\\))?$/",
+                    php_regex!("/^(\\d+)x(\\d+)(?: \\((\\d+)x(\\d+)\\))?$/"),
                     &shirabe_php_shim::trim(&ansicon.to_string_lossy(), None),
                     &mut matches,
                 )
@@ -143,7 +143,7 @@ impl Terminal {
             }
             let mut matches: Vec<Option<String>> = Vec::new();
             if shirabe_php_shim::preg_match(
-                "/rows.(\\d+);.columns.(\\d+);/i",
+                php_regex!("/rows.(\\d+);.columns.(\\d+);/i"),
                 &stty_string,
                 &mut matches,
             ) {
@@ -159,7 +159,7 @@ impl Terminal {
                     ))))
                 });
             } else if shirabe_php_shim::preg_match(
-                "/;.(\\d+).rows;.(\\d+).columns/i",
+                php_regex!("/;.(\\d+).rows;.(\\d+).columns/i"),
                 &stty_string,
                 &mut matches,
             ) {
@@ -187,7 +187,7 @@ impl Terminal {
         let info = info?;
         let mut matches: Vec<Option<String>> = Vec::new();
         if !shirabe_php_shim::preg_match(
-            "/--------+\\r?\\n.+?(\\d+)\\r?\\n.+?(\\d+)\\r?\\n/",
+            php_regex!("/--------+\\r?\\n.+?(\\d+)\\r?\\n.+?(\\d+)\\r?\\n/"),
             &info,
             &mut matches,
         ) {
-- 
cgit v1.3.1