From 91692846909ed191addb7ec1c34aad11392ab88b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 18 Jul 2026 15:03:55 +0900 Subject: perf(regex): eliminate per-call clone overhead in preg_* dispatch regex::Regex::clone() does not share the underlying meta engine's search-cache pool, so every fresh clone pays a ~10us warmup cost on its first use. Two changes together eliminate this across nearly all preg_* call sites: - A php_regex! macro resolves PHP-style patterns to a per-call-site &'static regex::Regex (via regex-macro's LazyLock), applied at the majority of call sites throughout the codebase. - Call sites still passing dynamic pattern strings go through PATTERN_CACHE, which now stores Arc<(Regex, bool)> and hands out Arc::clone()s instead of cloning the Regex itself. PregPattern::resolve() returns a ResolvedPattern enum (Arc or 'static reference) rather than an owned Regex, so neither path ever clones the Regex proper. Co-Authored-By: Claude Sonnet 5 --- crates/shirabe-external-packages/src/symfony/finder/finder.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/finder') diff --git a/crates/shirabe-external-packages/src/symfony/finder/finder.rs b/crates/shirabe-external-packages/src/symfony/finder/finder.rs index 7d3bdc10..c2b6c4cd 100644 --- a/crates/shirabe-external-packages/src/symfony/finder/finder.rs +++ b/crates/shirabe-external-packages/src/symfony/finder/finder.rs @@ -10,7 +10,7 @@ use crate::composer::pcre::{CaptureKey, Preg}; use crate::symfony::finder::glob::Glob; use chrono::{NaiveDate, NaiveDateTime}; use indexmap::{IndexMap, IndexSet}; -use shirabe_php_shim::{file_exists, glob, is_dir, preg_quote, rtrim}; +use shirabe_php_shim::{file_exists, glob, is_dir, php_regex, preg_quote, rtrim}; use std::path::{Path, PathBuf}; use std::time::UNIX_EPOCH; @@ -311,7 +311,7 @@ impl Finder { let dir = rtrim(dir, Some("/")); - if Preg::is_match("#^(ssh2\\.)?s?ftp://#", &dir) { + if Preg::is_match(php_regex!("#^(ssh2\\.)?s?ftp://#"), &dir) { format!("{dir}/") } else { dir @@ -660,7 +660,7 @@ fn is_regex(str: &str) -> bool { .unwrap_or_default(); if start == end { - return !Preg::is_match("/[*?[:alnum:] \\\\]/", &start); + return !Preg::is_match(php_regex!("/[*?[:alnum:] \\\\]/"), &start); } for (open, close) in [("{", "}"), ("(", ")"), ("[", "]"), ("<", ">")] { -- cgit v1.3.1