From 84655bf3a4a21dbbe7aec8e3aee1e661505bbb6d Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 23:37:42 +0900 Subject: feat(symfony-process): port full Process class from PHP Faithfully port every method, field and constant of Symfony's Process.php into process.rs, replacing the reduced stub. Add the supporting pipes module (PipesInterface/AbstractPipes/UnixPipes/ WindowsPipes), ProcessUtils and the missing process exceptions (LogicException/InvalidArgumentException) with constructors. Methods now return anyhow::Result where PHP throws, take the env argument and a bool-returning callback, and borrow &mut for status-updating accessors; all callers are updated accordingly. Extend the php-shim with proc_open/proc_close (PHP-compatible signatures), proc_get_status, proc_terminate, posix_kill, uniqid, ftruncate, ftell_stream, fseek3, stream_get_contents3 and env helpers. Co-Authored-By: Claude Opus 4.8 --- .../process/exception/process_failed_exception.rs | 34 ++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) (limited to 'crates/shirabe-external-packages/src/symfony/process/exception/process_failed_exception.rs') diff --git a/crates/shirabe-external-packages/src/symfony/process/exception/process_failed_exception.rs b/crates/shirabe-external-packages/src/symfony/process/exception/process_failed_exception.rs index 8957226..a3645d6 100644 --- a/crates/shirabe-external-packages/src/symfony/process/exception/process_failed_exception.rs +++ b/crates/shirabe-external-packages/src/symfony/process/exception/process_failed_exception.rs @@ -1,5 +1,6 @@ //! ref: composer/vendor/symfony/process/Exception/ProcessFailedException.php +use crate::symfony::process::exception::invalid_argument_exception::InvalidArgumentException; use crate::symfony::process::process::Process; #[derive(Debug)] @@ -9,8 +10,37 @@ pub struct ProcessFailedException { } impl ProcessFailedException { - pub fn new(_process: &Process) -> Self { - todo!() + pub fn new(process: &mut Process) -> anyhow::Result { + if process.is_successful() { + return Err(InvalidArgumentException::new( + "Expected a failed process, but the given process was successful.".to_string(), + ) + .into()); + } + + let mut error = format!( + "The command \"{}\" failed.\n\nExit Code: {}({})\n\nWorking directory: {}", + process.get_command_line(), + process + .get_exit_code() + .map(|c| c.to_string()) + .unwrap_or_default(), + process.get_exit_code_text().unwrap_or_default(), + process.get_working_directory().unwrap_or_default(), + ); + + if !process.is_output_disabled() { + error += &format!( + "\n\nOutput:\n================\n{}\n\nError Output:\n================\n{}", + process.get_output()?, + process.get_error_output()?, + ); + } + + Ok(Self { + message: error, + code: 0, + }) } } -- cgit v1.3.1