From 84655bf3a4a21dbbe7aec8e3aee1e661505bbb6d Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 23:37:42 +0900 Subject: feat(symfony-process): port full Process class from PHP Faithfully port every method, field and constant of Symfony's Process.php into process.rs, replacing the reduced stub. Add the supporting pipes module (PipesInterface/AbstractPipes/UnixPipes/ WindowsPipes), ProcessUtils and the missing process exceptions (LogicException/InvalidArgumentException) with constructors. Methods now return anyhow::Result where PHP throws, take the env argument and a bool-returning callback, and borrow &mut for status-updating accessors; all callers are updated accordingly. Extend the php-shim with proc_open/proc_close (PHP-compatible signatures), proc_get_status, proc_terminate, posix_kill, uniqid, ftruncate, ftell_stream, fseek3, stream_get_contents3 and env helpers. Co-Authored-By: Claude Opus 4.8 --- .../src/symfony/process/process_utils.rs | 47 ++++++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 crates/shirabe-external-packages/src/symfony/process/process_utils.rs (limited to 'crates/shirabe-external-packages/src/symfony/process/process_utils.rs') diff --git a/crates/shirabe-external-packages/src/symfony/process/process_utils.rs b/crates/shirabe-external-packages/src/symfony/process/process_utils.rs new file mode 100644 index 0000000..aec326f --- /dev/null +++ b/crates/shirabe-external-packages/src/symfony/process/process_utils.rs @@ -0,0 +1,47 @@ +//! ref: composer/vendor/symfony/process/ProcessUtils.php + +use shirabe_php_shim::{self as php, PhpMixed}; + +use crate::symfony::process::exception::invalid_argument_exception::InvalidArgumentException; + +/// ProcessUtils is a bunch of utility methods. +#[derive(Debug)] +pub struct ProcessUtils; + +impl ProcessUtils { + /// Validates and normalizes a Process input. + pub fn validate_input(caller: &str, input: PhpMixed) -> anyhow::Result { + if !input.is_null() { + if php::is_resource(&input) { + return Ok(input); + } + if php::is_string(&input) { + return Ok(input); + } + if php::is_scalar(&input) { + let s = match &input { + PhpMixed::Bool(b) => { + if *b { + "1".to_string() + } else { + String::new() + } + } + PhpMixed::Int(i) => i.to_string(), + PhpMixed::Float(f) => f.to_string(), + other => other.as_string().map(|s| s.to_string()).unwrap_or_default(), + }; + return Ok(PhpMixed::String(s)); + } + // TODO(plugin): Process / \Iterator / \Traversable inputs are not modeled by PhpMixed. + + return Err(InvalidArgumentException::new(format!( + "\"{}\" only accepts strings, Traversable objects or stream resources.", + caller + )) + .into()); + } + + Ok(input) + } +} -- cgit v1.3.1