From 530d085d4f3e19f94ac3cf8f8ac3b17000214b2e Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 18 Aug 2026 01:57:02 +0900 Subject: refactor(pcre): inline Preg into its call sites and drop the crate Preg had shed everything it owned: after the last few rounds its methods were one-line forwards to the shim's preg_*(), differing only in a default argument or a wrapper the caller unwrapped anyway. The 460 call sites now name the shim function, and shirabe-pcre is gone from the workspace along with its LICENSE entry. The forwards expand as they read: isMatch becomes preg_match2(.., 0).is_some() (is_none() where PHP negates it), isMatch3 and match3 drop the .is_some(), matchAll counts through preg_match_all2(..).occurrence_count(), and replace4/replace5 spell out the limit and count arguments preg_replace2 takes. Callbacks are the one place the shapes differ: preg_replace_callback carries an error out of the callback, so the fourteen infallible closures wrap their result in Ok() and expect() it back. Config::process() is the fifteenth, and it drops the `error` cell it captured to smuggle a failure past a closure that could only return a String. The `?` in the closure now carries it, which is what the PHP does -- a throw from the callback leaves preg_replace_callback at the failing match rather than running the remaining replacements and reporting the last error. The module doc that explained why composer/pcre's exceptions and *StrictGroups() variants have no counterpart moves to the shim's preg module, where the functions it describes live. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe-pcre/Cargo.toml | 16 ---------------- 1 file changed, 16 deletions(-) delete mode 100644 crates/shirabe-pcre/Cargo.toml (limited to 'crates/shirabe-pcre/Cargo.toml') diff --git a/crates/shirabe-pcre/Cargo.toml b/crates/shirabe-pcre/Cargo.toml deleted file mode 100644 index 4c884440..00000000 --- a/crates/shirabe-pcre/Cargo.toml +++ /dev/null @@ -1,16 +0,0 @@ -[package] -name = "shirabe-pcre" -version.workspace = true -edition.workspace = true -rust-version.workspace = true -description = "A Rust port of composer/pcre" -repository.workspace = true -license.workspace = true - -[dependencies] -shirabe-php-shim.workspace = true -indexmap.workspace = true -regex.workspace = true - -[lints] -workspace = true -- cgit v1.3.1-4-g156e