From b4ab3df2ec85fbe477d7721344a8cd3630b437a1 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 13:59:28 +0900 Subject: feat(plugin): guard Rust-owned classes the worker has no proxy for The worker's autoloader fell through to the real Composer source for every Rust-owned FQCN without a proxy stub, so plugin code doing `new Filesystem()` or subclassing `LibraryInstaller` silently ran on a second instance the Rust side never sees. An unimplemented part of the plugin API has to fail with an explicit error naming it, not quietly work on a disconnected copy. The stub generator now emits a guard class for each of those FQCNs: the real declaration, hierarchy and constants, with every constructor and method raising an explicit error. References satisfied by the declaration alone (`instanceof`, `X::class`, `Link::TYPE_REQUIRE`) keep working. Two FQCNs stay resolvable to the real class, each listed with the worker-side mechanism that makes a natively constructed instance correct. The error had nowhere to go: `Installer::run` dropped the `Result` of both `dispatch_script` calls, so an exception from a listener ended in exit 0. Both propagate now, the way the exception does upstream. Three real-plugin E2E comparisons stop at a guard and are ignored, each naming the class it needs. Co-Authored-By: Claude Opus 5 (1M context) --- .../Composer/DependencyResolver/Decisions.php | 145 +++++++++++++++++++++ .../Composer/DependencyResolver/DefaultPolicy.php | 55 ++++++++ .../Composer/DependencyResolver/GenericRule.php | 107 +++++++++++++++ .../DependencyResolver/LocalRepoTransaction.php | 20 +++ .../DependencyResolver/LockTransaction.php | 37 ++++++ .../DependencyResolver/MultiConflictRule.php | 107 +++++++++++++++ .../guards/Composer/DependencyResolver/Pool.php | 115 ++++++++++++++++ .../Composer/DependencyResolver/PoolBuilder.php | 37 ++++++ .../Composer/DependencyResolver/PoolOptimizer.php | 22 ++++ .../guards/Composer/DependencyResolver/Request.php | 126 ++++++++++++++++++ .../Composer/DependencyResolver/Rule2Literals.php | 107 +++++++++++++++ .../guards/Composer/DependencyResolver/RuleSet.php | 78 +++++++++++ .../DependencyResolver/RuleSetGenerator.php | 65 +++++++++ .../DependencyResolver/RuleSetIterator.php | 42 ++++++ .../SecurityAdvisoryPoolFilter.php | 25 ++++ .../guards/Composer/DependencyResolver/Solver.php | 58 +++++++++ .../Composer/DependencyResolver/Transaction.php | 39 ++++++ 17 files changed, 1185 insertions(+) create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Decisions.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/DefaultPolicy.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/GenericRule.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/LocalRepoTransaction.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/LockTransaction.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/MultiConflictRule.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Pool.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/PoolBuilder.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/PoolOptimizer.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Request.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Rule2Literals.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/RuleSet.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/RuleSetGenerator.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/RuleSetIterator.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/SecurityAdvisoryPoolFilter.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Solver.php create mode 100644 crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Transaction.php (limited to 'crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver') diff --git a/crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Decisions.php b/crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Decisions.php new file mode 100644 index 00000000..21d44992 --- /dev/null +++ b/crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/Decisions.php @@ -0,0 +1,145 @@ + 'PACKAGE', + self::TYPE_REQUEST => 'REQUEST', + self::TYPE_LEARNED => 'LEARNED', + ]; + + public function __construct() + { + \ShirabeUnsupportedClass::fail(self::class, '__construct'); + } + + public function add(Rule $rule, $type): void + { + \ShirabeUnsupportedClass::fail(self::class, 'add'); + } + + public function count(): int + { + \ShirabeUnsupportedClass::fail(self::class, 'count'); + } + + public function ruleById(int $id): Rule + { + \ShirabeUnsupportedClass::fail(self::class, 'ruleById'); + } + + public function getRules(): array + { + \ShirabeUnsupportedClass::fail(self::class, 'getRules'); + } + + public function getIterator(): RuleSetIterator + { + \ShirabeUnsupportedClass::fail(self::class, 'getIterator'); + } + + public function getIteratorFor($types): RuleSetIterator + { + \ShirabeUnsupportedClass::fail(self::class, 'getIteratorFor'); + } + + public function getIteratorWithout($types): RuleSetIterator + { + \ShirabeUnsupportedClass::fail(self::class, 'getIteratorWithout'); + } + + public function getTypes(): array + { + \ShirabeUnsupportedClass::fail(self::class, 'getTypes'); + } + + public function getPrettyString(?RepositorySet $repositorySet = null, ?Request $request = null, ?Pool $pool = null, bool $isVerbose = false): string + { + \ShirabeUnsupportedClass::fail(self::class, 'getPrettyString'); + } + + public function __toString(): string + { + \ShirabeUnsupportedClass::fail(self::class, '__toString'); + } +} diff --git a/crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/RuleSetGenerator.php b/crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/RuleSetGenerator.php new file mode 100644 index 00000000..4406ddda --- /dev/null +++ b/crates/shirabe-php-rpc/php/guards/Composer/DependencyResolver/RuleSetGenerator.php @@ -0,0 +1,65 @@ +