From d3bc3354c9705dfc6dc5e9b9adb5eb64d41e4c49 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sun, 30 Aug 2026 23:01:25 +0900
Subject: feat(plugin): serve ProcessExecutor as a proxy stub

Composer reaches this class two ways: the object graph hands one out through
Composer::getLoop()->getProcessExecutor(), and plugins write
`new ProcessExecutor($io)` freely. Both bind to a Rust-side entity, so the
timeout the run shares -- seeded from process-timeout and rewritten while the
run is in flight -- has one value instead of one per world, and the executor
can still be passed to the classes that take one (`new Filesystem($process)`).

Three things the stub generator was missing came with it:

- By-ref parameters. The call carries their positions and the answer carries
  what each holds afterwards; a position the answer omits was never assigned
  to, which is what PHP does with an untouched by-ref parameter.
  ProcessExecutor::execute is the only one on a proxied class.
- Argument arity, reproduced where the real body reads func_num_args().
  execute($cmd) forwards the child's output and execute($cmd, $out) captures
  it, and nothing but the argument count separates the two.
- Static methods that cannot run in the worker. One that reads a static
  property the Rust side owns, or that reaches a guarded class, forwards
  through __shirabeCallStatic instead of being materialized. That also fixes
  Filesystem::isLocalPath and getPlatformPath, whose materialized bodies
  called the guarded Composer\Util\Platform.

The async surface stays an explicit error. executeAsync resolves its promise
with a Symfony Process, whose proc_open() resource and pipes belong to
whichever process called start(), so a Rust-side spawn has none to hand back;
running the real start() in the worker needs a promise representation that
crosses the boundary unresolved.

The fixture project drives the whole synchronous surface from plugin code and
compares the trace against upstream Composer byte for byte.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 .../php/guards/Composer/Util/ProcessExecutor.php   | 114 ---------------------
 1 file changed, 114 deletions(-)
 delete mode 100644 crates/shirabe-php-rpc/php/guards/Composer/Util/ProcessExecutor.php

(limited to 'crates/shirabe-php-rpc/php/guards/Composer/Util')

diff --git a/crates/shirabe-php-rpc/php/guards/Composer/Util/ProcessExecutor.php b/crates/shirabe-php-rpc/php/guards/Composer/Util/ProcessExecutor.php
deleted file mode 100644
index 405905e8..00000000
--- a/crates/shirabe-php-rpc/php/guards/Composer/Util/ProcessExecutor.php
+++ /dev/null
@@ -1,114 +0,0 @@
-<?php
-
-// Generated by scripts/plugin-stub-generator; do not edit by hand.
-// Guard for Composer\Util\ProcessExecutor.
-// The Rust side owns this class and the worker has no proxy for it, so this
-// declaration shadows the real one: the constants and the hierarchy stay, while
-// constructing it or calling anything on it raises an explicit error.
-
-namespace Composer\Util;
-
-use Composer\IO\IOInterface;
-use React\Promise\PromiseInterface;
-
-class ProcessExecutor
-{
-    private const STATUS_QUEUED = 1;
-    private const STATUS_STARTED = 2;
-    private const STATUS_COMPLETED = 3;
-    private const STATUS_FAILED = 4;
-    private const STATUS_ABORTED = 5;
-    private const BUILTIN_CMD_COMMANDS = [
-        'assoc', 'break', 'call', 'cd', 'chdir', 'cls', 'color', 'copy', 'date',
-        'del', 'dir', 'echo', 'endlocal', 'erase', 'exit', 'for', 'ftype', 'goto',
-        'help', 'if', 'label', 'md', 'mkdir', 'mklink', 'move', 'path', 'pause',
-        'popd', 'prompt', 'pushd', 'rd', 'rem', 'ren', 'rename', 'rmdir', 'set',
-        'setlocal', 'shift', 'start', 'time', 'title', 'type', 'ver', 'vol',
-    ];
-    private const GIT_CMDS_NEED_GIT_DIR = [
-        ['show'],
-        ['log'],
-        ['branch'],
-        ['remote', 'set-url'],
-    ];
-
-    public function __construct(?IOInterface $io = null)
-    {
-        \ShirabeUnsupportedClass::fail(self::class, '__construct');
-    }
-
-    public function execute($command, &$output = null, ?string $cwd = null): int
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'execute');
-    }
-
-    public function executeTty($command, ?string $cwd = null): int
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'executeTty');
-    }
-
-    public function executeAsync($command, ?string $cwd = null): PromiseInterface
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'executeAsync');
-    }
-
-    protected function outputHandler(string $type, string $buffer): void
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'outputHandler');
-    }
-
-    public function setMaxJobs(int $maxJobs): void
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'setMaxJobs');
-    }
-
-    public function resetMaxJobs(): void
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'resetMaxJobs');
-    }
-
-    public function wait($index = null): void
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'wait');
-    }
-
-    public function enableAsync(): void
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'enableAsync');
-    }
-
-    public function countActiveJobs($index = null): int
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'countActiveJobs');
-    }
-
-    public function splitLines(?string $output): array
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'splitLines');
-    }
-
-    public function getErrorOutput(): string
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'getErrorOutput');
-    }
-
-    public static function getTimeout(): int
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'getTimeout');
-    }
-
-    public static function setTimeout(int $timeout): void
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'setTimeout');
-    }
-
-    public static function escape($argument): string
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'escape');
-    }
-
-    public function requiresGitDirEnv($command): bool
-    {
-        \ShirabeUnsupportedClass::fail(self::class, 'requiresGitDirEnv');
-    }
-}
-- 
cgit v1.3.1-4-g156e