From 9efc866ae2553a9c51abae7214f62dde4f5f053c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 2 Aug 2026 16:27:36 +0900 Subject: chore(todo): consolidate TODO comments into the five fixed marker tags Retag every Shirabe-authored TODO comment to one of the fixed tags: phase-c, phase-d, plugin, php-runtime, phase-e. Upstream-authored TODO comments from Composer/Symfony are left untouched to preserve the ported code shape. Co-Authored-By: Claude Fable 5 --- crates/shirabe-php-shim/src/array.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe-php-shim/src/array.rs') diff --git a/crates/shirabe-php-shim/src/array.rs b/crates/shirabe-php-shim/src/array.rs index 6c2004cf..29338aae 100644 --- a/crates/shirabe-php-shim/src/array.rs +++ b/crates/shirabe-php-shim/src/array.rs @@ -686,7 +686,7 @@ pub fn sort(_array: &mut Vec) { pub fn sort_with_flags(array: &mut [T], flags: i64) { if flags != SORT_REGULAR { - // TODO(phase-d): flag-specific comparison (SORT_NUMERIC/SORT_STRING/ + // TODO(phase-c): flag-specific comparison (SORT_NUMERIC/SORT_STRING/ // SORT_NATURAL/SORT_FLAG_CASE) cannot be expressed for a generic // `T: Ord` element. No caller passes a non-regular flag yet. todo!("sort() with flags other than SORT_REGULAR"); @@ -714,7 +714,7 @@ pub fn ksort(array: &mut IndexMap) { // PHP's default SORT_REGULAR comparison for array keys: two integer-like keys // compare numerically, otherwise byte-wise as strings. -// TODO(phase-d): full SORT_REGULAR semantics for mixed integer/non-numeric-string +// TODO(phase-c): full SORT_REGULAR semantics for mixed integer/non-numeric-string // keys are not reproduced; every current caller uses homogeneous string keys. fn php_sort_regular_key(a: &str, b: &str) -> std::cmp::Ordering { if let (Ok(na), Ok(nb)) = (a.parse::(), b.parse::()) -- cgit v1.3.1