From f4cad2123b2af0de72bda4ce039e16e74f163f4e Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 8 Aug 2026 22:14:12 +0900
Subject: feat(php-shim): give ported exceptions PHP's class hierarchy

Ported exceptions were flat structs reached with `downcast_ref`, so
Composer's `catch (\RuntimeException $e)` only matched the exact leaf
type and `get_class($e)` had nothing to report. Each exception now
embeds an instance of the class it extends and travels inside an
`AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and
`PhpClass::php_class_name` yields the PHP FQCN.

Dropping the `std::error::Error` impls from the exception types leaves
`AnyThrowable` as the only route into an `anyhow::Error`, so the walk
cannot be bypassed. A `no_exception_downcast` linter catches the
`downcast::<X>()` calls that would now silently answer `None`.

Three sites change behavior as a result: the `TransportException`
exit-code override reaches `MaxFileSizeExceededException`, the
`catch (\LogicException)` in findSimilar() reaches its subclasses, and
rendered exception titles carry the real class name rather than a
guess. `get_class_err()` is no longer a `todo!()`, which re-enables
FilesystemRepositoryTest::testCorruptedRepositoryFile.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 crates/shirabe-php-shim/src/fs.rs | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

(limited to 'crates/shirabe-php-shim/src/fs.rs')

diff --git a/crates/shirabe-php-shim/src/fs.rs b/crates/shirabe-php-shim/src/fs.rs
index c3f131b3..00ed6de3 100644
--- a/crates/shirabe-php-shim/src/fs.rs
+++ b/crates/shirabe-php-shim/src/fs.rs
@@ -184,13 +184,10 @@ pub fn recursive_directory_iterator(
 ) -> Result<RecursiveDirectoryIterator, UnexpectedValueException> {
     let root = _path.as_ref().to_path_buf();
     if !root.is_dir() {
-        return Err(UnexpectedValueException {
-            message: format!(
-                "RecursiveDirectoryIterator::__construct({}): Failed to open directory",
-                root.display()
-            ),
-            code: 0,
-        });
+        return Err(UnexpectedValueException::new(format!(
+            "RecursiveDirectoryIterator::__construct({}): Failed to open directory",
+            root.display()
+        )));
     }
     Ok(RecursiveDirectoryIterator {
         root,
@@ -255,12 +252,11 @@ pub fn directory_iterator(
     path: impl AsRef<std::path::Path>,
 ) -> Result<Vec<DirectoryIteratorEntry>, UnexpectedValueException> {
     let base = path.as_ref();
-    let rd = std::fs::read_dir(base).map_err(|_| UnexpectedValueException {
-        message: format!(
+    let rd = std::fs::read_dir(base).map_err(|_| {
+        UnexpectedValueException::new(format!(
             "DirectoryIterator::__construct({}): Failed to open directory",
             base.display()
-        ),
-        code: 0,
+        ))
     })?;
     // PHP's DirectoryIterator yields the "." and ".." entries before the real ones.
     let mut entries = vec![
-- 
cgit v1.3.1-4-g156e