From 96fcd5ef671579b5b75e01de99bbe54d8c1e877b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 10 Aug 2026 08:30:45 +0900 Subject: refactor(symfony-console): drop the unreachable process title surface MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Command::setProcessTitle has no caller: neither Composer nor the ported Symfony Console code sets a process title, so run()'s title branch could never fire. The shim it called into was unimplementable anyway — PHP rewrites its own argv block, which Rust hands out only as owned copies. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe-php-shim/src/process.rs | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'crates/shirabe-php-shim/src/process.rs') diff --git a/crates/shirabe-php-shim/src/process.rs b/crates/shirabe-php-shim/src/process.rs index 38ba9928..2b380c60 100644 --- a/crates/shirabe-php-shim/src/process.rs +++ b/crates/shirabe-php-shim/src/process.rs @@ -401,18 +401,6 @@ pub fn getmypid() -> i64 { std::process::id() as i64 } -pub fn cli_set_process_title(_title: &str) -> bool { - // TODO(phase-c): PHP rewrites the argv area so the new title shows up in ps(1)'s full command - // line. Rust hands out argv as owned copies, so the original block is not reachable; prctl's - // PR_SET_NAME only replaces the 16-byte comm field and would report a different title. - todo!() -} - -pub fn setproctitle(_title: &str) { - // TODO(phase-c): see cli_set_process_title; requires access to the process's own argv block. - todo!() -} - // No-op until real signal handling is wired up; signal registration itself is // deferred (see the TODO(plugin) notes in SignalRegistry::register). pub fn pcntl_async_signals(_enable: bool) {} -- cgit v1.3.1-4-g156e