From f1d65c337c63b6aa3582aabc64bfbbb2f949127c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 9 Aug 2026 07:29:10 +0900 Subject: test(platform): drop HHVM-only paths from HhvmDetector test shirabe never runs on HHVM, so the HHVM_VERSION_ID branches are dead. Dropping them leaves the shim's unimplemented `constant()` without a caller, so remove it as well. Co-Authored-By: Claude Opus 5 --- crates/shirabe-php-shim/src/runtime.rs | 6 ------ 1 file changed, 6 deletions(-) (limited to 'crates/shirabe-php-shim/src/runtime.rs') diff --git a/crates/shirabe-php-shim/src/runtime.rs b/crates/shirabe-php-shim/src/runtime.rs index 13513b9d..44cae087 100644 --- a/crates/shirabe-php-shim/src/runtime.rs +++ b/crates/shirabe-php-shim/src/runtime.rs @@ -43,12 +43,6 @@ pub const PHP_OS: &str = match std::env::consts::OS.as_bytes() { _ => std::env::consts::OS, }; -pub fn constant(_name: &str) -> PhpMixed { - // TODO(php-runtime): resolving a constant by name needs a runtime constant registry, which the shim - // does not provide (constants are ported as Rust `const`s, not looked up by string). - todo!() -} - // Models the constants defined in a standard modern PHP CLI environment on a // non-Windows platform with the common extensions loaded (curl, openssl, json). // Windows-only, HHVM and Composer-bootstrap constants are reported undefined. -- cgit v1.3.1-4-g156e