From f3d60c7836da0d50d59a22cfd6e4692e3dc75581 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 9 Aug 2026 05:59:40 +0900 Subject: test(console): cover the dev build warning branch The deadline is a constant baked in at build time, so PHP's define() of COMPOSER_DEV_WARNING_TIME cannot make Application take that branch. Application now holds the deadline in a field that __set_dev_warning_time overrides, letting testDevWarning run instead of staying ignored. The define() shim, whose only caller was that test, goes away with it. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe-php-shim/src/runtime.rs | 6 ------ 1 file changed, 6 deletions(-) (limited to 'crates/shirabe-php-shim/src/runtime.rs') diff --git a/crates/shirabe-php-shim/src/runtime.rs b/crates/shirabe-php-shim/src/runtime.rs index 05396b3b..c00c8f51 100644 --- a/crates/shirabe-php-shim/src/runtime.rs +++ b/crates/shirabe-php-shim/src/runtime.rs @@ -49,12 +49,6 @@ pub fn constant(_name: &str) -> PhpMixed { todo!() } -pub fn define(_constant_name: &str, _value: PhpMixed) -> bool { - // TODO(php-runtime): defining a constant at runtime needs the same registry `constant` and - // `defined` would read from; the shim has none. - todo!() -} - // Models the constants defined in a standard modern PHP CLI environment on a // non-Windows platform with the common extensions loaded (curl, openssl, json). // Windows-only, HHVM and Composer-bootstrap constants are reported undefined. -- cgit v1.3.1-4-g156e