From 9efc866ae2553a9c51abae7214f62dde4f5f053c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 2 Aug 2026 16:27:36 +0900 Subject: chore(todo): consolidate TODO comments into the five fixed marker tags Retag every Shirabe-authored TODO comment to one of the fixed tags: phase-c, phase-d, plugin, php-runtime, phase-e. Upstream-authored TODO comments from Composer/Symfony are left untouched to preserve the ported code shape. Co-Authored-By: Claude Fable 5 --- crates/shirabe-php-shim/src/zip.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/shirabe-php-shim/src/zip.rs') diff --git a/crates/shirabe-php-shim/src/zip.rs b/crates/shirabe-php-shim/src/zip.rs index 93b65fd5..83dd70ce 100644 --- a/crates/shirabe-php-shim/src/zip.rs +++ b/crates/shirabe-php-shim/src/zip.rs @@ -248,7 +248,7 @@ impl ZipArchive { } pub fn set_external_attributes_name(&self, _name: &str, _opsys: i64, _attr: i64) -> bool { - // TODO(phase-d): PHP's setExternalAttributesName mutates an already-added + // TODO(phase-c): PHP's setExternalAttributesName mutates an already-added // entry's external attributes (e.g. Unix permissions) after addFile. The // `zip` crate fixes external attributes at start_file time via FileOptions // and exposes no API to amend a written entry, so this cannot be faithfully -- cgit v1.3.1