From 40bb49fc0b80d5ff97875903b2c2e55ff394cecc Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 27 Jun 2026 20:19:56 +0900 Subject: refactor(http): present reqwest instead of faking curl_version - StreamContextFactory: User-Agent reports the HTTP stack as "reqwest" - RequestProxy::supports_secure_proxy: always true (reqwest+rustls can always TLS to a proxy); drop the now-dead curl<7.52 guard in get_curl_options - DiagnoseCommand::get_curl_version: phase-D TODO placeholder Empirically verified: reqwest sends no default User-Agent (shirabe sets it explicitly) and accepts https:// proxy URLs. init+install output stays byte-identical to Composer. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe-php-shim/src/curl.rs | 3 +++ 1 file changed, 3 insertions(+) (limited to 'crates/shirabe-php-shim/src') diff --git a/crates/shirabe-php-shim/src/curl.rs b/crates/shirabe-php-shim/src/curl.rs index 316e8fd..35ba391 100644 --- a/crates/shirabe-php-shim/src/curl.rs +++ b/crates/shirabe-php-shim/src/curl.rs @@ -75,6 +75,9 @@ pub struct CurlMultiHandle; pub struct CurlShareHandle; pub fn curl_version() -> Option> { + // Shirabe's HTTP layer is reqwest, not libcurl; no consumer needs real curl_version() data + // (the User-Agent reports "reqwest", RequestProxy::supports_secure_proxy is unconditionally + // true, and DiagnoseCommand has a phase-D TODO). Left unimplemented until a real need arises. todo!() } -- cgit v1.3.1